checklocks: guard VFS dynamic device majors - #14263
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @nybidari for the dynamic-major map guards and initialization/restore lock scopes. Both VFS analysis checks passed for amd64 and arm64. The runtime suite is blocked locally by the baseline macOS build failure in pkg/fd (unix.O_LARGEFILE); the afterLoad path was reviewed from source. Assisted-by: Codex |
Dynamic character-device allocation protects its used-major map and shared-key cache with dynCharDevMajorMu, but the contract is only documented in prose. Add guards for both maps and the locked allocation helper. Hold the mutex while initializing the maps and repairing a nil shared cache after load so these lifecycle paths follow the same contract. Assisted-by: Codex
tamird
force-pushed
the
checklocks-vfs-device-majors
branch
from
August 21, 2026 23:08
d4d06bd to
9906c80
Compare
Contributor
Author
|
Closing in favor of consolidated #14343. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic character-device allocation protects its used-major map and shared-key cache with dynCharDevMajorMu, but the contract is only documented in prose. Add guards for both maps and the locked allocation helper.
Hold the mutex while initializing the maps and repairing a nil shared cache after load so these lifecycle paths follow the same contract.
Assisted-by: Codex