checklocks: guard socket option state - #14266
Closed
tamird wants to merge 1 commit into
Closed
Conversation
SocketOptions documents locking for its error queue and linger option, but checklocks does not enforce those contracts. Add field guards using the mutexes already held by their accessors and replace the redundant locking prose. Assisted-by: Codex
Contributor
Author
|
r? @nybidari — could you review the error-queue and linger guards, given your recent SocketOptions work?
Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SocketOptions documents locking for its error queue and linger option, but checklocks does not enforce those contracts. Add field guards using the mutexes already held by their accessors and replace the redundant locking prose.
Assisted-by: Codex