checklocks: enforce user namespace lock ownership - #14285
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @EtiennePerot Could you review user-namespace, key-registry and map-installation lock ownership? Focused local Bazel checks passed. No upstream build/test result is reported yet. The reviewer-assignment check failed with HTTP 422 because at least one selected reviewer is not an eligible repository collaborator. The job does not identify which account. This is an assignment-automation failure, not a build/test failure; the review request above remains in place. Assisted-by: Codex |
Enforce the existing mutexes for namespace ID maps, inode references and key registries. Initialize the key map through the locked transaction view instead of the untracked outer receiver. Declare the namespace lock required by map installation helpers, whose callers retain it through rollback. Exempt only address-taking before self-locking map helpers, leaving their non-reentry contracts checked. The map argument's namespace ownership remains an explicit precondition. Distinguish the immutable creation-time capability snapshot from mutable namespace state. Assisted-by: Codex
tamird
force-pushed
the
checklocks-auth-state
branch
from
August 22, 2026 16:19
45b6e39 to
4eeb73f
Compare
Contributor
Author
|
Closing in favor of consolidated #14345. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the existing mutexes for user namespace inode references, setgroups permission, and key registries. Initialize the key map through the locked transaction view instead of the untracked outer receiver.
Declare the namespace lock required by UID/GID map installation helpers, whose callers retain it through rollback. Distinguish the immutable creation-time capability snapshot from mutable namespace state.
Assisted-by: Codex