checklocks: enforce terminal state locks - #14291
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @EtiennePerot Could you review terminal state, queue transformations and notification ownership? Focused local Bazel checks passed. Upstream checks are pending. Assisted-by: Codex |
Enforce the existing locks for terminal configuration, size, replica count, packet-mode status, queue buffers, and cursor position. Declare the termios and queue requirements through reads, writes, character processing, and buffered input transfer. Keep interface transformation requirements explicit: checklocks verifies concrete implementations but does not propagate their contracts through interface dispatch. Annotate both paths to the output queue mutex and limit callback exceptions to accesses made by synchronous userspace copies while the queue mutex is held. Assisted-by: Codex
tamird
force-pushed
the
checklocks-devpts-line-state
branch
from
August 22, 2026 16:19
864938c to
47917b4
Compare
Contributor
Author
|
Closing in favor of consolidated #14343. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the existing locks for terminal configuration, size, replica count, and packet-mode status. Declare the termios and queue requirements through reads, writes, character processing, and buffered input transfer.
Keep the interface transformation preconditions explicit in prose: the checker verifies concrete implementations but does not propagate their contracts through interface dispatch. Retain queue and cursor ownership comments where callback and receiver aliasing prevent field annotations.
Assisted-by: Codex