checklocks: guard gonet connection state - #14299
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Guard deadline timers and cancellation channels with the deadline mutex, and check the caller-held contract on setDeadline. Guard the TCP read buffer with readMu while preserving the readMu-before-deadline-mutex lock order. Construct deadline state as a fresh value so initialization is visible to checklocks. Timer callbacks retain their captured cancellation channel, preserving deadline reset behavior without copying a used mutex. Assisted-by: Codex
Contributor
Author
|
r? @nybidari Could you review deadline timer/channel ownership and TCP read-buffer lock order? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard deadline timers and cancellation channels with the deadline mutex, and check the caller-held contract on setDeadline. Guard the TCP read buffer with readMu while preserving the readMu-before-deadline-mutex lock order.
Construct deadline state as a fresh value so initialization is visible to checklocks. Timer callbacks retain their captured cancellation channel, preserving deadline reset behavior without copying a used mutex.
Assisted-by: Codex