checklocks: guard KCOV and deferred task work - #14304
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @shailend-g Could you review KCOV/task-work ownership and the unlocked callback phase? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
Enforce existing KCOV state and deferred-task-work mutex contracts. Require atomic access to the task-work count, allowing lock-free reads while checking that updates hold the queue mutex. Preserve countBlock's borrowed-memory lifetime requirement and explain why its entry annotation cannot constrain later BlockSeq accesses. Keep task-work callbacks outside the queue lock so they may register additional work. Assisted-by: Codex
tamird
force-pushed
the
checklocks-kcov-task-work
branch
from
August 22, 2026 16:19
f1f8c96 to
65ecfe0
Compare
Contributor
Author
|
Closing in favor of consolidated #14345. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce existing KCOV state and deferred-task-work mutex contracts. Preserve countBlock's borrowed-memory lifetime requirement and the unlocked callback phase that lets task work register additional work.
Assisted-by: Codex