checklocks: enforce Kernel state ownership - #14305
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @shailend-g Could you review Kernel and TaskSet state, iteration and lifecycle contracts? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
Guard kernel start/save state, scheduler notifications, socket and container registries, device gofers and user-counter bookkeeping with their owner mutexes. Initialize guarded maps and scheduler channels in short owner-lock sections that end before filesystem callbacks and state loading; setup and restore still require an unused kernel. Require atomic access to scheduling, clock, ID and user counters. Guard TaskSet stop and exit bookkeeping, including the WaitExited creation barrier, and require its read lock for task iteration. Retain the stopped-task condition on time pause/resume helpers. Explain immutable global-init publication, proc's stored atomic pointers and process-group TaskSet aliases where checklocks cannot follow the ownership proof. Keep those lifetime and callback constraints explicit without initializer exemptions or locks spanning restore callbacks. Assisted-by: Codex
tamird
force-pushed
the
checklocks-kernel-state
branch
from
August 22, 2026 16:19
089a7ee to
cf11313
Compare
Contributor
Author
|
Closing in favor of consolidated #14345. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the start/save flags, socket sequence and cgroup/device registries with their existing mutexes. Require atomic accesses to scheduling, clock, ID and user counters.
Guard TaskSet stop and exit bookkeeping, including the creation barrier after WaitExited, and require its read lock for task iteration. Require extMu in the time pause/resume helpers while retaining the stopped-task precondition. Document initialization-only and shared pointer access paths where a uniform field guard would not describe ownership.
Assisted-by: Codex