checklocks: fix proc network sysctl ownership - #14321
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Proc file descriptions share sysctl sources, so per-FD locks do not protect cached state. Read the port range and TCP SACK setting from the synchronized stack instead of retaining unsynchronized duplicate caches. Rejected SACK writes no longer change the value read back. The old netstack replacement path was removed by f4da28b. Enforce the mutex protecting PortManager's authoritative ephemeral range with checklocks. Keep the synchronous reservation callback's caller-held lock contract explicit where it cannot yet be annotated. Forwarding intentionally retains the last-written value introduced by 600d14f. Give that source its own mutex and serialize the cache update with SetForwarding. Cover cross-source readback and rejected SACK writes. Assisted-by: Codex
Contributor
Author
|
r? @nybidari Could you review authoritative SACK/port-range readback and forwarding serialization? Focused local Bazel checks passed. No upstream build/test result is reported yet. cc @milantracy The reviewer-assignment check failed with HTTP 422 because at least one selected reviewer is not an eligible repository collaborator. The job does not identify which account. This is an assignment-automation failure, not a build/test failure; the review request above remains in place. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proc file descriptions share sysctl sources, so per-FD locks do not protect cached state. Read the port range and TCP SACK setting from the synchronized stack instead of retaining unsynchronized duplicate caches. Rejected SACK writes no longer change the value read back. The old netstack replacement path was removed by f4da28b.
Enforce the mutex protecting PortManager's authoritative ephemeral range with checklocks. Keep the synchronous reservation callback's caller-held lock contract explicit where it cannot yet be annotated.
Forwarding intentionally retains the last-written value introduced by 600d14f. Give that source its own mutex and serialize the cache update with SetForwarding. Cover cross-source readback and rejected SACK writes.
Assisted-by: Codex