checklocks: fix signal-delivery error exit - #14328
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Since aeabb78, runInterrupt calls PrepareGroupExit while holding the signal mutex if PullFullState fails. The wrapper tries to acquire that mutex again, preventing the task from exiting. Use the locked helper and release the mutex before returning runExit. Annotate both helper contracts so checklocks catches recursive entry. Current built-in platform contexts return nil from PullFullState. Exercise the error handling with an injected failure, checking SIGILL group-exit state and mutex release. Assisted-by: Codex
Contributor
Author
|
r? @shailend-g Could you review the locked group-exit helper and mutex release on signal-delivery failure? Focused local Bazel checks passed. Upstream checks are pending. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14345. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since aeabb78, runInterrupt calls PrepareGroupExit while holding the signal mutex if PullFullState fails. The wrapper tries to acquire that mutex again, preventing the task from exiting.
Use the locked helper and release the mutex before returning runExit. Annotate both helper contracts so checklocks catches recursive entry.
Current built-in platform contexts return nil from PullFullState. Exercise the error handling with an injected failure, checking SIGILL group-exit state and mutex release.
Assisted-by: Codex