checklocks: guard event broadcaster state - #14332
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
r? @EtiennePerot Could you review subscription-table and backing-storage ownership? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
Enforce the broadcaster mutex contract for its subscription table, load, ID allocation and self-locking entry points. Document how the same mutex protects slot contents and insertion into shared backing storage, while unpublished storage can be initialized under exclusive ownership. Slots and table slices have no link back to the owning broadcaster, so their mutex requirements cannot be named by checklocks. Explain that receiver callbacks run synchronously under the broadcaster mutex and must not reenter it; the callback interface also loses that owner. Assisted-by: Codex
tamird
force-pushed
the
checklocks-syncevent-broadcaster
branch
from
August 22, 2026 16:19
1930ead to
c964e10
Compare
Contributor
Author
|
Closing in favor of consolidated #14289. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the broadcaster mutex contract for its subscription table, load, and ID allocation. Document how the same mutex protects slot contents and insertion into shared backing storage, while unpublished storage can be initialized under exclusive ownership.
Assisted-by: Codex