checklocks: enforce SysV IPC lock ownership - #14334
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Guard registry access, queue accounting, semaphore metadata, and SHM lifecycle state with their existing owner mutexes. Annotate caller-held helper and destruction contracts, concrete lock effects, and locks excluded by the final SHM reference drop. Preserve immutable IDs, externally owned IPC metadata, semaphore payloads, and unlocked waiter registration. Document SHM key versus ID lifetime and keep final reference drops outside the registry and segment locks. Existing semaphore tests acquire the locks required by the new contracts. Assisted-by: Codex
Contributor
Author
|
r? @milantracy Could you review SysV IPC registry, semaphore and SHM lifetime/lock contracts? Focused local Bazel checks passed. No upstream build/test result is reported yet. cc @aaltinaydev The reviewer-assignment check failed with HTTP 422 because at least one selected reviewer is not an eligible repository collaborator. The job does not identify which account. This is an assignment-automation failure, not a build/test failure; the review request above remains in place. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14345. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard registry access, queue accounting, semaphore metadata, and SHM lifecycle state with their existing owner mutexes. Annotate caller-held helper and destruction contracts, concrete lock effects, and locks excluded by the final SHM reference drop.
Preserve immutable IDs, externally owned IPC metadata, semaphore payloads, and unlocked waiter registration. Document SHM key versus ID lifetime and keep final reference drops outside the registry and segment locks. Existing semaphore tests acquire the locks required by the new contracts.
Assisted-by: Codex