checklocks: guard task control state - #14335
Open
tamird wants to merge 1 commit into
Open
Conversation
Guard existing task mutex contracts for scheduling, NUMA, privilege state, and destruction callbacks. Initialize the virtual CPU with an atomic Store so its mixed atomic/mutex contract is checked throughout the task lifetime, including construction. Preserve CPU-mask ownership and unlocked callback execution. Document that start-time writes require Task.mu and the TaskSet mutex, while reads may hold either. Assisted-by: Codex
Contributor
Author
|
r? @shailend-g Could you review task control metadata and the virtual-CPU atomic/mutex contract? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard existing task mutex contracts for scheduling, NUMA, privilege state, and destruction callbacks. Initialize the virtual CPU with an atomic Store so its mixed atomic/mutex contract is checked throughout the task lifetime, including construction.
Preserve CPU-mask ownership and unlocked callback execution. Document that start-time writes require Task.mu and the TaskSet mutex, while reads may hold either.
Assisted-by: Codex