checklocks: publish initialized TCP endpoint IDs - #14337
Closed
tamird wants to merge 1 commit into
Closed
Conversation
TCP ICMP errors read endpoint addresses and ports without taking the endpoint mutex since 62b4c2f. An active connection previously published its selected ephemeral tuple before assigning it to the endpoint, so an incoming error could race with that assignment or report a zero local port. Assign the selected port before registering the endpoint and restore the old ID if registration fails. Taking the endpoint mutex in the ICMP reader would deadlock synchronous loopback errors during writes. Extend the existing connect-error test to deliver a matching ICMP error as soon as the endpoint is registered. Pause the handshake clock before SYN allocation so later synchronization cannot hide the publication race. Assisted-by: Codex
Contributor
Author
|
r? @nybidari Could you review initializing endpoint IDs before demux publication without ICMP re-entry deadlocks? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
Contributor
Author
|
Closing in favor of consolidated #14338. The expanded replacement commits are prepared locally; the replacement branch has not been pushed yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP ICMP errors read endpoint addresses and ports without taking the endpoint mutex since 62b4c2f. An active connection previously published its selected ephemeral tuple before assigning it to the endpoint, so an incoming error could race with that assignment or report a zero local port.
Assign the selected port before registering the endpoint and restore the old ID if registration fails. Taking the endpoint mutex in the ICMP reader would deadlock synchronous loopback errors during writes.
Extend the existing connect-error test to deliver a matching ICMP error as soon as the endpoint is registered. Pause the handshake clock before SYN allocation so later synchronization cannot hide the publication race.
Assisted-by: Codex