checklocks: enforce timer lock contracts - #14339
Open
tamird wants to merge 1 commit into
Open
Conversation
Guard sampled-timer settings and pause state, and synthetic-clock time and timer indexing. Enforce their existing locked-helper contracts while preserving lock-free atomic time reads and exclusive initialization. Document the owning-clock mutex for queued timer state, whose collection member identity is not tracked by checklocks. Assisted-by: Codex
Contributor
Author
|
r? @EtiennePerot Could you review sampled/synthetic timer locking and queued-timer owner identity? Focused local Bazel checks passed. No upstream build/test result is reported yet. The reviewer-assignment check failed with HTTP 422 because at least one selected reviewer is not an eligible repository collaborator. The job does not identify which account. This is an assignment-automation failure, not a build/test failure; the review request above remains in place. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard sampled-timer settings and pause state, and synthetic-clock time and timer indexing. Enforce their existing locked-helper contracts while preserving lock-free atomic time reads and exclusive initialization.
Document the owning-clock mutex for queued timer state, whose collection member identity is not tracked by checklocks.
Assisted-by: Codex