checklocks: enforce UDP endpoint lock contracts - #14340
Open
tamird wants to merge 1 commit into
Open
Conversation
Require the error mutex for the last error, and the endpoint mutex for read shutdown and binding. Exclude endpoint locks while writing: a synchronous loopback ICMP error can reacquire the read lock and deadlock behind a waiting writer. Document the endpoint lock held through synchronous registration callbacks, which checklocks cannot currently follow. Assisted-by: Codex
Contributor
Author
|
r? @nybidari Could you review UDP error, shutdown and binding contracts, including send-time lock exclusion? Focused local Bazel checks passed. Upstream checks have not reported yet. Assisted-by: Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require the error mutex for the last error, and the endpoint mutex for read shutdown and binding. Exclude endpoint locks while writing: a synchronous loopback ICMP error can reacquire the read lock and deadlock behind a waiting writer.
Document the endpoint lock held through synchronous registration callbacks, which checklocks cannot currently follow.
Assisted-by: Codex