Keep devpts mount options off root and ptmx - #15225
Merged
Merged
Conversation
51a3d72 applied mode, uid and gid to replicas but still used the uid and gid options for the root directory and ptmx. Linux initializes the root as namespace root and ptmx with the mounting process's identity [1, 2]. Keep those owners independent of the replica options. Consolidate SetGid into SetMode's option table and retain its group-write mode assertion. Check root, ptmx and replica ownership for default and explicit options, and keep each private mount's cleanup active. [1]: https://github.com/torvalds/linux/blob/830b3c68c/fs/devpts/inode.c [2]: https://github.com/torvalds/linux/blob/830b3c68c/fs/inode.c Assisted-by: OpenAI Codex
copybara-service
Bot
force-pushed
the
test/cl992446873
branch
from
October 2, 2026 19:31
6ac613b to
06f987c
Compare
PiperOrigin-RevId: 992497181
copybara-service
Bot
force-pushed
the
test/cl992446873
branch
from
October 2, 2026 20:13
06f987c to
8c3c0f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep devpts mount options off root and ptmx
51a3d72 applied mode, uid and gid to replicas but still used the uid and gid options for the root directory and ptmx. Linux initializes the root as namespace root and ptmx with the mounting process's identity 1 2. Keep those owners independent of the replica options.
Consolidate SetGid into SetMode's option table and retain its group-write mode assertion. Check root, ptmx and replica ownership for default and explicit options, and keep each private mount's cleanup active.
Assisted-by: OpenAI Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15162 from tamird:devpts-mount-options b07ccec