Fixing a bug in 'TestMath' which didnt handle the case correctly when both min and max were negative leading to no tests running for that case and ending with the max ulp error 0 if both min and max were passed negative.#2949
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 30, 2026
Conversation
copybara-service
bot
force-pushed
the
test_890950214
branch
2 times, most recently
from
db49708 to
12728f5
Compare
… both min and max were negative leading to no tests running for that case and ending with the max ulp error 0 if both min and max were passed negative. Fixing up the error bounds and comments for FastExp and FastExp2 based on this. PiperOrigin-RevId: 891675949
copybara-service
bot
force-pushed
the
test_890950214
branch
from
12728f5 to
374767c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug in 'TestMath' which didnt handle the case correctly when both min and max were negative leading to no tests running for that case and ending with the max ulp error 0 if both min and max were passed negative.
Fixing up the error bounds and comments for FastExp and FastExp2 based on this.