Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions ink/brush/brush_behavior.cc
Original file line number Diff line number Diff line change
Expand Up @@ -494,9 +494,9 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::Source source) {
case BrushBehavior::Source::
kAccelerationLateralInCentimetersPerSecondSquared:
case BrushBehavior::Source::kDistanceRemainingAsFractionOfStrokeLength:
return Version::k0Jetpack1_0_0();
return Version::k0();
case BrushBehavior::Source::kTimeSinceStrokeEndInSeconds:
return Version::k1Jetpack1_1_0Alpha01();
return Version::k1();
case BrushBehavior::Source::kTimeFromInputToStrokeEndInSeconds:
return Version::kDevelopment();
}
Expand All @@ -520,7 +520,7 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::Target target) {
case BrushBehavior::Target::kSaturationMultiplier:
case BrushBehavior::Target::kLuminosityOffset:
case BrushBehavior::Target::kOpacityMultiplier:
return Version::k0Jetpack1_0_0();
return Version::k0();
case BrushBehavior::Target::kTextureAnimationProgressOffset:
return Version::kDevelopment();
}
Expand All @@ -533,7 +533,7 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::PolarTarget target) {
kPositionOffsetAbsoluteInRadiansAndMultiplesOfBrushSize:
case BrushBehavior::PolarTarget::
kPositionOffsetRelativeInRadiansAndMultiplesOfBrushSize:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -544,7 +544,7 @@ Version CalculateMinimumRequiredVersion(
case BrushBehavior::OutOfRange::kClamp:
case BrushBehavior::OutOfRange::kMirror:
case BrushBehavior::OutOfRange::kRepeat:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -553,13 +553,13 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::BinaryOp operation) {
switch (operation) {
case BrushBehavior::BinaryOp::kProduct:
case BrushBehavior::BinaryOp::kSum:
return Version::k0Jetpack1_0_0();
return Version::k0();
case BrushBehavior::BinaryOp::kMin:
case BrushBehavior::BinaryOp::kMax:
case BrushBehavior::BinaryOp::kAndThen:
case BrushBehavior::BinaryOp::kOrElse:
case BrushBehavior::BinaryOp::kXorElse:
return Version::k1Jetpack1_1_0Alpha01();
return Version::k1();
}
return Version::kDevelopment();
}
Expand All @@ -570,7 +570,7 @@ Version CalculateMinimumRequiredVersion(
case BrushBehavior::ProgressDomain::kDistanceInCentimeters:
case BrushBehavior::ProgressDomain::kDistanceInMultiplesOfBrushSize:
case BrushBehavior::ProgressDomain::kTimeInSeconds:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -580,7 +580,7 @@ Version CalculateMinimumRequiredVersion(
switch (interpolation) {
case BrushBehavior::Interpolation::kLerp:
case BrushBehavior::Interpolation::kInverseLerp:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -596,7 +596,7 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::SourceNode node) {
}

Version CalculateMinimumRequiredVersion(BrushBehavior::ConstantNode node) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

Version CalculateMinimumRequiredVersion(BrushBehavior::NoiseNode node) {
Expand All @@ -608,16 +608,16 @@ Version CalculateMinimumRequiredVersion(
return std::max({
enabled.unknown
? CalculateMinimumRequiredVersion(StrokeInput::ToolType::kUnknown)
: Version::k0Jetpack1_0_0(),
: Version::k0(),
enabled.mouse
? CalculateMinimumRequiredVersion(StrokeInput::ToolType::kMouse)
: Version::k0Jetpack1_0_0(),
: Version::k0(),
enabled.touch
? CalculateMinimumRequiredVersion(StrokeInput::ToolType::kTouch)
: Version::k0Jetpack1_0_0(),
: Version::k0(),
enabled.stylus
? CalculateMinimumRequiredVersion(StrokeInput::ToolType::kStylus)
: Version::k0Jetpack1_0_0(),
: Version::k0(),
});
}

Expand All @@ -636,8 +636,7 @@ Version CalculateMinimumRequiredVersion(BrushBehavior::ResponseNode node) {

Version CalculateMinimumRequiredVersion(BrushBehavior::IntegralNode node) {
return std::max(
{Version::k1Jetpack1_1_0Alpha01(),
CalculateMinimumRequiredVersion(node.integrate_over),
{Version::k1(), CalculateMinimumRequiredVersion(node.integrate_over),
CalculateMinimumRequiredVersion(node.integral_out_of_range_behavior)});
}

Expand Down Expand Up @@ -666,7 +665,7 @@ Version CalculateMinimumRequiredVersion(const BrushBehavior::Node& node) {
}

Version CalculateMinimumRequiredVersion(const BrushBehavior& behavior) {
Version max_version = Version::k0Jetpack1_0_0();
Version max_version = Version::k0();
for (const auto& node : behavior.nodes) {
max_version = std::max(max_version, CalculateMinimumRequiredVersion(node));
}
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/brush_family.cc
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ absl::Status ValidateInputModel(const BrushFamily::InputModel& model) {
}

Version CalculateMinimumRequiredVersion(const BrushFamily::InputModel& model) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

std::string ToFormattedString(const BrushFamily::InputModel& model) {
Expand Down
12 changes: 6 additions & 6 deletions ink/brush/brush_paint.cc
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ Version CalculateMinimumRequiredVersion(
case BrushPaint::TextureOrigin::kStrokeSpaceOrigin:
case BrushPaint::TextureOrigin::kFirstStrokeInput:
case BrushPaint::TextureOrigin::kLastStrokeInput:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -344,7 +344,7 @@ Version CalculateMinimumRequiredVersion(
switch (texture_size_unit) {
case BrushPaint::TextureSizeUnit::kBrushSize:
case BrushPaint::TextureSizeUnit::kStrokeCoordinates:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -354,7 +354,7 @@ Version CalculateMinimumRequiredVersion(BrushPaint::TextureWrap texture_wrap) {
case BrushPaint::TextureWrap::kRepeat:
case BrushPaint::TextureWrap::kMirror:
case BrushPaint::TextureWrap::kClamp:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -373,7 +373,7 @@ Version CalculateMinimumRequiredVersion(BrushPaint::BlendMode blend_mode) {
case BrushPaint::BlendMode::kSrcOut:
case BrushPaint::BlendMode::kDstAtop:
case BrushPaint::BlendMode::kXor:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand All @@ -382,7 +382,7 @@ Version CalculateMinimumRequiredVersion(
BrushPaint::AnimationRepeatMode animation_repeat_mode) {
switch (animation_repeat_mode) {
case BrushPaint::AnimationRepeatMode::kRestart:
return Version::k0Jetpack1_0_0();
return Version::k0();
case BrushPaint::AnimationRepeatMode::kReverse:
return Version::kDevelopment();
}
Expand All @@ -394,7 +394,7 @@ Version CalculateMinimumRequiredVersion(BrushPaint::SelfOverlap self_overlap) {
case BrushPaint::SelfOverlap::kAny:
case BrushPaint::SelfOverlap::kDiscard:
case BrushPaint::SelfOverlap::kAccumulate:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/brush_tip.cc
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ absl::Status ValidateBrushTip(const BrushTip& tip) {
}

Version CalculateMinimumRequiredVersion(const BrushTip& tip) {
Version max_version = Version::k0Jetpack1_0_0();
Version max_version = Version::k0();
for (const auto& behavior : tip.behaviors) {
max_version =
std::max(max_version, CalculateMinimumRequiredVersion(behavior));
Expand Down
4 changes: 2 additions & 2 deletions ink/brush/color_function.cc
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ namespace {

Version CalculateMinimumRequiredVersion(
const ColorFunction::OpacityMultiplier& opacity) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

Version CalculateMinimumRequiredVersion(const ColorFunction::HueOffset& hue) {
Expand All @@ -188,7 +188,7 @@ Version CalculateMinimumRequiredVersion(

Version CalculateMinimumRequiredVersion(
const ColorFunction::ReplaceColor& replace) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

Version CalculateMinimumRequiredVersion(
Expand Down
8 changes: 4 additions & 4 deletions ink/brush/easing_function.cc
Original file line number Diff line number Diff line change
Expand Up @@ -156,18 +156,18 @@ Version CalculateMinimumRequiredVersion(
case EasingFunction::Predefined::kEaseInOut:
case EasingFunction::Predefined::kStepStart:
case EasingFunction::Predefined::kStepEnd:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}

Version CalculateMinimumRequiredVersion(
const EasingFunction::CubicBezier& cubic_bezier) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

Version CalculateMinimumRequiredVersion(const EasingFunction::Linear& linear) {
return Version::k0Jetpack1_0_0();
return Version::k0();
}

Version CalculateMinimumRequiredVersion(const EasingFunction::Steps& steps) {
Expand All @@ -190,7 +190,7 @@ Version CalculateMinimumRequiredVersion(
case EasingFunction::StepPosition::kJumpStart:
case EasingFunction::StepPosition::kJumpNone:
case EasingFunction::StepPosition::kJumpBoth:
return Version::k0Jetpack1_0_0();
return Version::k0();
}
return Version::kDevelopment();
}
Expand Down
4 changes: 2 additions & 2 deletions ink/brush/internal/jni/brush_native_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ namespace ink::native {
Version IntToVersion(int version) {
switch (version) {
case 0:
return Version::k0Jetpack1_0_0();
return Version::k0();
case 1:
return Version::k1Jetpack1_1_0Alpha01();
return Version::k1();
case std::numeric_limits<int32_t>::max():
return Version::kDevelopment();
default:
Expand Down
24 changes: 14 additions & 10 deletions ink/brush/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,19 @@ class Version {

std::string ToFormattedString() const { return absl::StrCat(value_); }

// Brush version is incremented when new features are ready to be released.
// This is a versioning process independent of the Jetpack version. A Jetpack
// version may have multiple brush version increments, or none at all
// (containing only previously released brush versions).

// Included with Jetpack 1.1.0-alpha01.
static constexpr Version k1Jetpack1_1_0Alpha01() { return Version(1); }
// Included with Jetpack 1.0.0.
static constexpr Version k0Jetpack1_0_0() { return Version(0); }
// A Version represents a version of the Ink library's custom brush
// serialization format. This is independent of the Jetpack version. A Jetpack
// release may have multiple brush version increments, or none at all
// (containing only previously released brush versions). Version is used to
// determine compatibility of serialized brushes which may be shared across
// apps using different releases of this library.

// Included with
// [Jetpack 1.1.0-alpha01](https://developer.android.com/jetpack/androidx/releases/ink#1.1.0-alpha01).
static constexpr Version k1() { return Version(1); }
// Included with
// [Jetpack 1.0.0](https://developer.android.com/jetpack/androidx/releases/ink#1.0.0).
static constexpr Version k0() { return Version(0); }

// Features associated with kDevelopment will always be rejected by the
// deserializer due to kDevelopment > kMaxSupported. The only exception is
Expand All @@ -42,7 +46,7 @@ class Version {
// customization format. Features still under development should be associated
// with kDevelopment until they are ready to be released, after which they
// are expected to be supported long-term.
static constexpr Version kMaxSupported() { return k1Jetpack1_1_0Alpha01(); }
static constexpr Version kMaxSupported() { return k1(); }

private:
explicit constexpr Version(int32_t value) : value_(value) {
Expand Down
Loading
Loading