Skip to content

secops-soar: clarify certifi setup failures - #262

Closed
Haihan-Jiang wants to merge 1 commit into
google:mainfrom
Haihan-Jiang:fix-soar-certifi-error
Closed

secops-soar: clarify certifi setup failures#262
Haihan-Jiang wants to merge 1 commit into
google:mainfrom
Haihan-Jiang:fix-soar-certifi-error

Conversation

@Haihan-Jiang

Copy link
Copy Markdown
Contributor

Summary

  • keep the underlying SOAR request error so startup can distinguish TLS certificate failures from credential failures
  • show a certifi/Install Certificates.command hint when fetching SOAR scopes fails because certificate verification failed
  • add the same macOS certifi setup note to the top-level README

Before/after evidence

Before, the certifi setup failure was reported as a credentials problem:

Failed to fetch valid scopes from SOAR, please make sure you have configured the right SOAR credentials. Shutting down...

After this change, the certificate path produces a specific setup hint:

Failed to fetch valid scopes from SOAR because TLS certificate verification failed. If you are using the Python.org macOS installer, run the Install Certificates.command for your Python version, for example: `/Applications/Python\ 3.12/Install\ Certificates.command`. You can also point Python at certifi's CA bundle with `SSL_CERT_FILE=$(python -m certifi)`.

Tests

  • python3 -m py_compile server/secops-soar/secops_soar_mcp/bindings.py server/secops-soar/secops_soar_mcp/http_client.py server/secops-soar/secops_soar_mcp/bindings_test.py
  • PYTHONPATH=server/secops-soar /tmp/mcp-security-secops-venv/bin/python -m pytest -q server/secops-soar/secops_soar_mcp/bindings_test.py
  • git diff --check

Fixes #191

@Haihan-Jiang
Haihan-Jiang marked this pull request as ready for review May 26, 2026 18:10
@Haihan-Jiang
Haihan-Jiang requested a review from a team May 26, 2026 18:10
@Haihan-Jiang

Copy link
Copy Markdown
Contributor Author

This is ready for review. The certifi setup failure message is clearer now, and the visible checks are green.

@dandye

dandye commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Thank you for this contribution. This PR has been superseded by #295, which incorporates actionable TLS and certifi startup diagnostics for macOS into a structured exception hierarchy across the SOAR HTTP client. Closing in favor of #295.

@dandye dandye closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message and docs for the SOAR certifi issue

2 participants