Fix UI window centering, python requirements and resource links broke…#56
Open
OskarYescas wants to merge 1 commit into
Open
Fix UI window centering, python requirements and resource links broke…#56OskarYescas wants to merge 1 commit into
OskarYescas wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on customer feedback, this PR addresses Ui changes.
Documentation Updates (README.md)
Added an explicit note to the "Python Version" requirements section advising users to avoid Python Beta or Release Candidate (RC) versions, as they were observed causing installation errors for dependencies.
Window Centering (ui/utils.py, migration_planner.py, ui/exchange_online_ui.py, ui/chats_ui.py)
Created a lightweight center_window helper function in ui/utils.py.
The main selector window and all three workload estimator windows (Exchange, Chat, Files) now consistently launch dead-center on the user's screen rather. Previously, this caused some misplacements if using different monitors.
Resource Links Fix (ui/exchange_online_ui.py, ui/chats_ui.py)
Fixed an issue where clicking the "Learn more" resource links did nothing.
Imported the missing webbrowser standard library and successfully bound the webbrowser.open() action.
Added cursor="hand2" to the link labels to provide immediate visual feedback that the text is clickable.
Currerntly, the redirect links are the same (should be updated).
Testing
Successfully tested all three UI views locally on macOS.
Verified that links open the system's default browser correctly.
Verified that all screens center flawlessly upon launch.