Add a DelegatingReplicaJpaTransactionManager to handle multiple replicas#3005
Open
gbrodman wants to merge 1 commit intogoogle:masterfrom
Open
Add a DelegatingReplicaJpaTransactionManager to handle multiple replicas#3005gbrodman wants to merge 1 commit intogoogle:masterfrom
gbrodman wants to merge 1 commit intogoogle:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ain/java/google/registry/persistence/transaction/DelegatingReplicaJpaTransactionManager.java
Dismissed
Show dismissed
Hide dismissed
Collaborator
Author
|
Tested on alpha by adding a second replica, including both replica names on the SQL_REPLICA_CONN_NAMES keyring secret, and removing the old SQL_REPLICA_CONN_NAME secret |
weiminyu
approved these changes
Apr 10, 2026
Collaborator
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 12 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
Collaborator
Author
|
for posterity, i also tested in crash without changing any of the secret manager keys or the replica situation and it still worked |
This will allow us to spread the load across multiple Postgres replica instances which should help with latency and stability.
gbrodman
force-pushed
the
multipleReplicas
branch
from
d5aab2b to
8801f49
Compare
Collaborator
Author
|
(most recent update was just changing the copyright date since gemini kept overwriting it with 2024 for some reason) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to spread the load across multiple Postgres replica instances which should help with latency and stability.
This change is