Map GCB trigger subs to environment vars - #3208
Merged
Merged
Conversation
Also quote the variables. Passing the variables through the "env" block means that we avoid any situations where the characters trigger some evaluation. https://docs.cloud.google.com/build/docs/configuring-builds/substitute-variable-values G.4 number 2 b/535251126
jicelhay
approved these changes
Aug 14, 2026
jicelhay
left a comment
jicelhay
left a comment
Collaborator
There was a problem hiding this comment.
@jicelhay reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also quote the variables.
Passing the variables through the "env" block means that we avoid any situations where the characters trigger some evaluation.
https://docs.cloud.google.com/build/docs/configuring-builds/substitute-variable-values
This hasn't caused any issues, but is a general good-practice sort of thing.
G.4 number 2
b/535251126
This change is