[PowerPlay] Add Local Playback and support#2363
Merged
madebymozart merged 8 commits intomainfrom Apr 8, 2026
Merged
Conversation
* Remove redundant comments and documentation blocks across `MainActivity.kt` and `PowerPlayMultiPlayer.cpp`. * Delete an unused Kotlin compiler session file.
robertwu1
reviewed
Apr 8, 2026
Collaborator
Author
There was a problem hiding this comment.
There song is still there, I just updated it to be 44.1/16 bit instead of 44.1/32 bit to assure it still worked
robertwu1
reviewed
Apr 8, 2026
|
|
||
| private val dynamicPlayList = mutableStateListOf<Music>() | ||
| private val isLoadingFile = mutableStateOf(false) | ||
|
|
Collaborator
There was a problem hiding this comment.
Please fix the new lines in this file. There are too many large gaps
robertwu1
reviewed
Apr 8, 2026
| env->GetByteArrayRegion(bytearray, 0, len, reinterpret_cast<jbyte *>(buf)); | ||
|
|
||
| MemInputStream stream(buf, len); | ||
| WavStreamReader reader(&stream); |
Collaborator
There was a problem hiding this comment.
Take a look at https://github.com/google/oboe/blob/1c48a817d2d6a07adf867986a32c96cbf84367b0/samples/parselib/src/main/cpp/wav/WavStreamReader.cpp.
This file should work for the majority of files but this is a very basic wav file parser. Please download a variety of WAV files to make sure it works. Thanks!
robertwu1
reviewed
Apr 8, 2026
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif No newline at end of file |
Collaborator
There was a problem hiding this comment.
New line at the end of files
robertwu1
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability for local file playback to powerplay and Wav Info