feat: Log the flow.run_local_server redirect URL#362
Open
mafrosis wants to merge 4 commits intogoogleapis:mainfrom
Open
feat: Log the flow.run_local_server redirect URL#362mafrosis wants to merge 4 commits intogoogleapis:mainfrom
mafrosis wants to merge 4 commits intogoogleapis:mainfrom
Conversation
chalmerlowe
added a commit
that referenced
this pull request
Jan 23, 2026
This commit adds a detailed technical review of PR #362 to REVIEW.md, covering functional correctness, adherence to Google Python standards, and suggested refactors. Co-authored-by: chalmerlowe <7291104+chalmerlowe@users.noreply.github.com>
Draft
product-auto-label
bot
added
size: s
chalmerlowe
reviewed
Feb 6, 2026
Remove unnecessary logger.setlevel command.
chalmerlowe
added
the
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running this library in a headless environment, it's often the case that
printis not captured and delivered to the end user. By also logging theauth_url, a user of this library could ensure that the auth url reaches the logs.Also set the module's logger level to
INFO, as it was hanging asNOTSETin the current implementation.I'm unable to run the full
noxsuite locally, but it looks like nothing has broken. I'll make any changes needed when the CI tests run.