Skip to content

feat(bigquery-jdbc): implement clearcut transport layer#13738

Merged
Neenu1995 merged 4 commits into
jdbc-telemetry-featurefrom
jdbc-telemetry-pr6
Jul 14, 2026
Merged

feat(bigquery-jdbc): implement clearcut transport layer#13738
Neenu1995 merged 4 commits into
jdbc-telemetry-featurefrom
jdbc-telemetry-pr6

Conversation

@Neenu1995

Copy link
Copy Markdown
Contributor

No description provided.

@Neenu1995 Neenu1995 requested review from a team as code owners July 13, 2026 21:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ClearcutTransport class and its corresponding unit tests to handle uploading telemetry payloads to Clearcut. The review feedback highlights critical issues in the retry loop implementation, such as dead code from default exception throwing on non-2xx status codes, immediate retries without backoff, and unnecessary retries on non-retryable client errors (e.g., 400 Bad Request). The reviewer recommends explicitly disabling exception throwing on execute errors, using try-with-resources for response cleanup, restricting retries to 429 and 5xx status codes with proper backoff, and adding a unit test to verify that non-retryable errors do not trigger retries.

@Neenu1995 Neenu1995 merged commit 5b46669 into jdbc-telemetry-feature Jul 14, 2026
156 checks passed
@Neenu1995 Neenu1995 deleted the jdbc-telemetry-pr6 branch July 14, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants