feat(bigquery-jdbc): implement clearcut transport layer#13738
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ClearcutTransport class and its corresponding unit tests to handle uploading telemetry payloads to Clearcut. The review feedback highlights critical issues in the retry loop implementation, such as dead code from default exception throwing on non-2xx status codes, immediate retries without backoff, and unnecessary retries on non-retryable client errors (e.g., 400 Bad Request). The reviewer recommends explicitly disabling exception throwing on execute errors, using try-with-resources for response cleanup, restricting retries to 429 and 5xx status codes with proper backoff, and adding a unit test to verify that non-retryable errors do not trigger retries.
logachev
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.