-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(gax-java): add JSpecify Null annotations to gax #13799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nnicolee
wants to merge
34
commits into
main
Choose a base branch
from
feat/jspecify-gax-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5a85552
testing automation tool on gax
nnicolee 9f25a79
running automation tool on gax-java
nnicolee f4e63af
feat(gax): refactor javax to jspecify type-use null annotations
nnicolee 471b684
testing automation tool on gax
nnicolee 1887dc5
running automation tool on gax-java
nnicolee 7a0c69e
feat(gax): refactor javax to jspecify type-use null annotations
nnicolee 805997e
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee 81b33cf
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee 1ca35b7
Merge branch 'feat/jspecify-gax-auth' of github.com:googleapis/google…
nnicolee ce4b81b
declare jspecify dependencies
nnicolee 84806ee
test: disable copying annotations on mocks for Java 8 for sdk-platfor…
nnicolee 178b92a
fix previous errors on disabling copying annotations
nnicolee 629620a
fix further for disable copying annotations
nnicolee 5b6153c
Merge branch 'feat/jspecify-gax-auth' of github.com:googleapis/google…
nnicolee a11f36e
test: disable copying annotations on ApiTracerContext mocks for Java …
nnicolee 5214eb8
test(bigtable): fix remaining JSpecify CI issues on Java 8
lqiu96 20bbada
more disable mock annotation copying
nnicolee 8b73c7d
fixed the remaining mocks
nnicolee e333068
Merge branch 'fix-jspecify-ci-bigtable-mockito' into pr-13799
lqiu96 7c99224
fixed the rest of the mocks
nnicolee 91c37e8
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee fba10fa
add JSpecify dependency to Bazel BUILD files
nnicolee d8ebf04
Merge branch 'feat/jspecify-gax-auth' of github.com:googleapis/google…
nnicolee c094849
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee 5e37306
revert: added back import mock for bigtable test
nnicolee bf8da72
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee 5b0dbec
revert: added back import for Answers for bigtable test
nnicolee 81ce6d1
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee 619e82d
ran linting on java-bigtable test
nnicolee 5f6018f
Merge branch 'main' into feat/jspecify-gax-auth
nnicolee ea14da7
Merge branch 'main' of github.com:googleapis/google-cloud-java into f…
nnicolee 8f0db45
updated following gemini suggestions
nnicolee 4c8ab1b
Merge branch 'feat/jspecify-gax-auth' of github.com:googleapis/google…
nnicolee b2edaa3
addressed gemini code review #2
nnicolee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.