test(bigquery-jdbc): fix JSpecify compatibility issues on Java 8#13818
Conversation
Update Mockito mocks in BigQuery JDBC tests to ignore annotations, preventing ArrayStoreException when running tests on Java 8. Specifically, mock Page, ApiException, and StatusCode classes with withSettings().withoutAnnotations(). TAG=agy CONV=de3ef09d-a26c-4190-b578-4c993f807bdc
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several unit tests in BigQueryConnectionTest, BigQueryDatabaseMetaDataTest, and BigQueryStatementTest to mock classes (such as Page, ApiException, and StatusCode) using Mockito's withSettings().withoutAnnotations(). A review comment correctly points out that BigQueryDatabaseMetaDataTest.java is missing the static import for withSettings, which will cause a compilation error.
| Routine otherProc = mockBigQueryRoutine(catalog, schema, "another_proc", "PROCEDURE", "p3"); | ||
|
|
||
| Page<Routine> page = mock(Page.class); | ||
| Page<Routine> page = mock(Page.class, withSettings().withoutAnnotations()); |
There was a problem hiding this comment.
The static import for withSettings is missing in this file, which will cause a compilation error. Please add import static org.mockito.Mockito.withSettings; to the imports section of this file, similar to the changes made in BigQueryConnectionTest.java and BigQueryStatementTest.java.
2 participants
Update Mockito mocks in BigQuery JDBC tests to ignore annotations, preventing ArrayStoreException when running tests on Java 8. Specifically, mock Page, ApiException, and StatusCode classes with withSettings().withoutAnnotations().