deps: Update Protobuf-Java to v4.33.6#13876
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| <gson.version>2.13.2</gson.version> | ||
| <guava.version>33.5.0-jre</guava.version> | ||
| <protobuf.version>4.33.2</protobuf.version> | ||
| <protobuf.version>4.33.6</protobuf.version> |
There was a problem hiding this comment.
Can we upgrade gen code in the same PR as well?
| local_path: sdk-platform-java/hermetic_build/library_generation | ||
| protoc: | ||
| version: "33.2" | ||
| version: "33.6" |
There was a problem hiding this comment.
Can we run librarian generate --all in the same PR to update the gen code? I think we may have to manually update it and push it to the same branch. cc: @zhumin8 @JoeWang1127.
There was a problem hiding this comment.
Yes.
Also, line 52 needs to update as well.
There was a problem hiding this comment.
Oh right. Happy to start a separate discussion on this or to create a librarian ticket if that is better, but is it possible to move this generation step to a nightly build so the Java team doesn't need to remember when to invoke librarian commands?
I would love for librarian generate --all to run automatically on every PR, but IIRC there are limitations that prevent that from happening.
There was a problem hiding this comment.
I'll help regenerate the repo as @lqiu96 has issues with local setup.
Feel feel to file an issue in librarian repo if you have issues running librarian command.
|
|
3 participants
No description provided.