docs: add JSpecify nullness guidelines to AGENTS.md#13881
Open
nnicolee wants to merge 2 commits into
Open
Conversation
nnicolee
marked this pull request as ready for review
July 23, 2026 19:44
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
going to update this to be |
lqiu96
changed the title
lqiu96
reviewed
Jul 23, 2026
lqiu96
reviewed
Jul 23, 2026
lqiu96
reviewed
Jul 23, 2026
lqiu96
reviewed
Jul 23, 2026
lqiu96
approved these changes
Jul 23, 2026
lqiu96
left a comment
lqiu96
left a comment
Member
There was a problem hiding this comment.
I think this is fine to test this out for the agent. I think there may be better spots for this (e.g. DEVELOPMENT.md or a specific null annotation skill to not increase up the initial context).
Shouldn't have any harm with trying this out for now and we can always move this around to any better spot in the future.
diegomarquezp
approved these changes
Jul 23, 2026
nnicolee
added
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated JSpecify Nullness Guidelines section (Section 5) to the repository-wide
AGENTS.mdonboarding guide for AI coding assistants.Changes
gapic-generator-java).@NullMarkeddefaulting, and details specific type-use placement rules for:List<@Nullable String> list)String @Nullable [] array)com.google.auth.oauth2.@Nullable TokenVerifier)