feat(storage): add support for DirectPath over Interconnect by nidhiii-27 · Pull Request #14006 · googleapis/google-cloud-java

nidhiii-27 · 2026-08-06T07:54:30Z

DirectPath over Interconnect Support (GAX): Added the attemptDirectPathXdsOverInterconnect option to enable on-premise xDS name resolution via the google-c2p:///<service>?force-xds target scheme.
GCP Platform Check Bypass: Modified DirectPath validation logic to bypass standard Google Compute Engine (GCE) environment checks when Interconnect is enabled.
Custom URI Validation: Enhanced endpoint validation to support and validate custom target URI formats containing the :/// syntax (e.g. google-c2p:///).
Storage Layer Integration: Added configuration options to GrpcStorageOptions to automatically rewrite hosts to storage-direct.googleapis.com and override the request authority to storage.googleapis.com for secure TLS handshakes.

gemini-code-assist

Code Review

This pull request introduces support for DirectPath xDS over Interconnect (on-premise xDS name resolution) in GrpcStorageOptions and InstantiatingGrpcChannelProvider, allowing GCE environment checks to be bypassed when enabled. It also updates endpoint validation to support custom URI schemes like google-c2p:/// and adds corresponding tests. The reviewer suggests dynamically adjusting the log level for the DirectPath fallback warning to avoid excessive warning spam in non-GCE environments, recommending Level.WARNING on GCE and Level.FINE elsewhere.

snippet-bot · 2026-09-04T08:45:25Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

…tion

[Generated-by: AI]

fix spanner tests failing due to overridden authority for default builder branch [Generated-by: AI]

kalragauri · 2026-09-04T10:05:00Z

+      "Bypassed because DirectPath over Interconnect (GCI) requires a specialized hybrid network environment (Interconnect and Traffic Director configured for storage-direct) and cannot be validated in standard CI or local workstations.")
+  @Test
+  public void clientShouldWork_directPathXdsOverInterconnect() throws Exception {
+    assumeTrue(


nit: having @ignore alongside assumeTrue is redundant because JUnit skips @ignore methods unconditionally at discovery time before assumeTrue can run.

We kept assumeTrue alongside @Ignore as an intentional defensive safeguard: storage-direct.googleapis.com is only resolvable in private Interconnect environments and fails name resolution on standard workstations and public CI runners. If @Ignore is lifted in the future (or if tests are executed by a runner that enables ignored tests), assumeTrue ensures the test skips gracefully with an AssumptionViolatedException rather than breaking CI with an UnknownHostException.

Co-authored by AI Agent

Could we add a comment in the test noting that assumeTrue is intentionally kept as a second-line dynamic guard so future refactors don't clean it up as redundant?

…nect - Generalize DirectPath over Interconnect host and authority handling in InstantiatingGrpcChannelProvider for any service using -direct. convention - Rethrow RuntimeException in extractTargetFromChannelBuilder to surface reflection errors in CI - Remove unused DEFAULT_HOST_DIRECT_PATH constant in GrpcStorageOptions - Add generic non-GCS unit tests in InstantiatingGrpcChannelProviderTest [Generated-by: AI]

- Define DIRECT_PATH_INTERCONNECT_INFIX constant to eliminate duplicated "-direct." string literals - Add explanatory comment in empty catch block of extractAuthorityFromChannelBuilder [Generated-by: AI]

…on in tests - Remove unintended positive test filter from Surefire plugin configuration in gax-grpc/pom.xml, allowing all standard unit tests in InstantiatingGrpcChannelProviderTest to run and restore code coverage. - Inspect authorityOverride field and unwrap builder delegates in InstantiatingGrpcChannelProviderTest#extractAuthorityFromChannelBuilder. [Generated-by: AI]

Replace 4 duplicate invalid endpoint tests with a single parameterized test to address SonarCloud java:S5976. [Generated-by: AI]

sonarqubecloud · 2026-09-07T09:15:30Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.8% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-09-07T09:17:18Z

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

kalragauri · 2026-09-07T12:31:23Z

+    }
+    if (rest.startsWith(oldHost)) {
+      int len = oldHost.length();
+      if (rest.length() == len || rest.charAt(len) == ':' || rest.charAt(len) == '/') {


A host/authority component can also be immediately followed by a query delimiter (?) or fragment delimiter (#) (e.g., https://storage.googleapis.com?query=val).

Should we include ? and # to ensure full RFC compliance?

kalragauri · 2026-09-07T12:32:26Z

+        java.lang.reflect.Field field = null;
+        while (clazz != null) {
+          try {
+            field = clazz.getDeclaredField("authority");


IIUC, we can eliminate reflection entirely by using Mockito with RETURNS_SELF on ManagedChannelBuilder.

kalragauri · 2026-09-07T12:33:19Z

+      "Bypassed because DirectPath over Interconnect (GCI) requires a specialized hybrid network environment (Interconnect and Traffic Director configured for storage-direct) and cannot be validated in standard CI or local workstations.")
+  @Test
+  public void clientShouldWork_directPathXdsOverInterconnect() throws Exception {
+    assumeTrue(


Could we add a comment in the test noting that assumeTrue is intentionally kept as a second-line dynamic guard so future refactors don't clean it up as redundant?

feat(storage): add support for DirectPath over Interconnect

23147be

gemini-code-assist Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread ...ax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java

nidhiii-27 marked this pull request as ready for review August 6, 2026 08:45

nidhiii-27 requested review from a team as code owners August 6, 2026 08:45

nidhiii-27 added 2 commits August 6, 2026 10:54

chore: ignore integration test due to environment constraints

213ada7

Merge branch 'main' into add-dp-over-gci

c1b4f5f

kalragauri reviewed Aug 27, 2026

View reviewed changes

nidhiii-27 added 2 commits September 1, 2026 06:30

Merge branch 'main' into add-dp-over-gci

e0177bd

fix(storage): resolve review comments for DirectPath over Interconnect

aee5030

ShreyasSinha requested changes Sep 2, 2026

View reviewed changes

Comment thread ...-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java

ShreyasSinha reviewed Sep 2, 2026

View reviewed changes

Comment thread ...-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java

nidhiii-27 force-pushed the add-dp-over-gci branch from 6b73da7 to d2bdc4a Compare September 4, 2026 08:45

nidhiii-27 force-pushed the add-dp-over-gci branch from d2bdc4a to 21b3acf Compare September 4, 2026 08:48

fix(storage): conditionally override authority and add BetaApi annota…

fb844cb

…tion

nidhiii-27 force-pushed the add-dp-over-gci branch from 21b3acf to fb844cb Compare September 4, 2026 08:57

nidhiii-27 added 2 commits September 4, 2026 09:09

style(storage): fix formatting and checkstyle lint issues

618641b

[Generated-by: AI]

style(storage): fix formatting and checkstyle lint issues

580252a

fix spanner tests failing due to overridden authority for default builder branch [Generated-by: AI]

kalragauri reviewed Sep 4, 2026

View reviewed changes

nidhiii-27 requested a review from ShreyasSinha September 7, 2026 05:14

nidhiii-27 added 4 commits September 7, 2026 06:03

style(gax-grpc): resolve SonarCloud code quality issues on PR #14006

2a9ed3b

- Define DIRECT_PATH_INTERCONNECT_INFIX constant to eliminate duplicated "-direct." string literals - Add explanatory comment in empty catch block of extractAuthorityFromChannelBuilder [Generated-by: AI]

test(gax-grpc): parameterize endpoint validation tests

640c499

Replace 4 duplicate invalid endpoint tests with a single parameterized test to address SonarCloud java:S5976. [Generated-by: AI]

nidhiii-27 requested a review from kalragauri September 7, 2026 09:31

kalragauri approved these changes Sep 7, 2026

View reviewed changes

Uh oh!

Conversation

nidhiii-27 commented Aug 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snippet-bot Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

No region tags are edited in this PR.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kalragauri Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

nidhiii-27 Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

kalragauri Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 7, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud Bot commented Sep 7, 2026

Quality Gate failed for 'gapic-generator-java-root'

Uh oh!

kalragauri Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

kalragauri Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

kalragauri Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

snippet-bot Bot commented Sep 4, 2026 •

edited

Loading