Skip to content

chore: update .nycrc, Contributing.md, and .gitignore across packages #9144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bshaffer wants to merge 2 commits into
base: pnpm
Choose a base branch
from
Draft

chore: update .nycrc, Contributing.md, and .gitignore across packages #9144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b45a3c
chore: update .nycrc, Contributing.md, .gitignore, and package.json p…
bshaffer Aug 13, 2026
c1db173
fix(generator): sync pnpm-lock.yaml and cast ServiceConfig for protob…
bshaffer Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 3 additions & 1 deletion .nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": [
"lcov"
],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,14 +342,14 @@ with an issue in this repository.

1. Install dependencies:

npm install
pnpm install

1. Run the tests:

npm test
pnpm run test

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
1 change: 0 additions & 1 deletion core/common/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ system-test/*key.json
*-lock.js*
build/
.vscode
package-lock.json
__pycache__
4 changes: 3 additions & 1 deletion core/common/.nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": [
"lcov"
],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
6 changes: 3 additions & 3 deletions core/common/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ accept your pull requests.

1. Install dependencies:

npm install
pnpm install

1. Run the tests:

# Run unit tests.
npm test
pnpm run test

@gemini-code-assist gemini-code-assist Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In this file (and many other CONTRIBUTING.md files across the repository), the command npm run samples-test on line 61 was missed during the migration from npm to pnpm. Please update it to pnpm run samples-test for consistency.


# Run sample integration tests.
npm run samples-test
Expand All @@ -65,7 +65,7 @@ accept your pull requests.

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
Expand Down
1 change: 0 additions & 1 deletion core/dev-packages/jsdoc-fresh/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
node_modules
package-lock.json
__pycache__
docs
.DS_Store
4 changes: 3 additions & 1 deletion core/dev-packages/jsdoc-fresh/.nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": [
"lcov"
],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
6 changes: 3 additions & 3 deletions core/dev-packages/jsdoc-fresh/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ accept your pull requests.

1. Install dependencies:

npm install
pnpm install

1. Run the tests:

# Run unit tests.
npm test
pnpm run test

# Run sample integration tests.
npm run samples-test
Expand All @@ -65,7 +65,7 @@ accept your pull requests.

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
Expand Down
1 change: 0 additions & 1 deletion core/dev-packages/jsdoc-region-tag/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
node_modules
.DS_Store
coverage
package-lock.json
.coverage
docs
4 changes: 3 additions & 1 deletion core/dev-packages/jsdoc-region-tag/.nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": [
"lcov"
],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
6 changes: 3 additions & 3 deletions core/dev-packages/jsdoc-region-tag/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ accept your pull requests.

1. Install dependencies:

npm install
pnpm install

1. Run the tests:

# Run unit tests.
npm test
pnpm run test

# Run sample integration tests.
npm run samples-test
Expand All @@ -65,7 +65,7 @@ accept your pull requests.

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
Expand Down
2 changes: 0 additions & 2 deletions core/dev-packages/pack-n-play/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ build
node_modules
.nyc_output
.coverage/*
test/fixtures/**/package-lock.json
package-lock.json
4 changes: 3 additions & 1 deletion core/dev-packages/pack-n-play/.nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": [
"lcov"
],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
6 changes: 3 additions & 3 deletions core/dev-packages/pack-n-play/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ accept your pull requests.

1. Install dependencies:

npm install
pnpm install

1. Run the tests:

# Run unit tests.
npm test
pnpm run test

# Run sample integration tests.
npm run samples-test
Expand All @@ -65,7 +65,7 @@ accept your pull requests.

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
Expand Down
6 changes: 3 additions & 3 deletions ...c-generator-typescript/baselines-esm/duplicate_methods_test-esm/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ accept your pull requests.

1. Install dependencies:

npm install
pnpm install

@gemini-code-assist gemini-code-assist Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It appears that CONTRIBUTING.md (and potentially .gitignore files) in the baseline and test-fixture directories are being manually updated here. According to the repository rules, manual edits to auto-generated files or baseline files should be avoided as they will be overwritten during the next regeneration. Please ensure that the upstream generator templates (or the source files used by the generator) are updated instead, and then regenerate these baseline/test-fixture files.

References
  1. Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.


1. Run the tests:

# Run unit tests.
npm test
pnpm run test

# Run sample integration tests.
npm run samples-test
Expand All @@ -67,7 +67,7 @@ accept your pull requests.

1. Lint (and maybe fix) any changes:

npm run fix
pnpm run fix

[setup]: https://cloud.google.com/nodejs/docs/setup
[projects]: https://console.cloud.google.com/project
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/asset-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/asset/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/bigquery-storage-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/bigquery-storage/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/bigquery-v2-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/bigquery-v2/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/compute-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/compute/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/deprecatedtest-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/deprecatedtest/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/disable-packing-test-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/disable-packing-test/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/dlp-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/dlp/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion ...generator/gapic-generator-typescript/baselines/duplicate_methods_test-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/duplicate_methods_test/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/kms-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/kms/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/logging-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/logging/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/monitoring-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/monitoring/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
2 changes: 1 addition & 1 deletion core/generator/gapic-generator-typescript/baselines/naming-esm/.nycrc.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],
"exclude": [
"**/*-test",
"**/.coverage",
Expand Down
Loading
Loading