chore: librarian onboard pull request: 20260304T233807Z#16026
Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the onboarding of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated onboarding of the google-cloud-hypercomputecluster v1 client library. The changes primarily consist of adding new, generated files for this version and updating existing configurations and documentation. I've identified a few minor issues: a duplicated header in the documentation that could affect rendering, and several unsorted __all__ lists which could be improved for better maintainability. My review includes suggestions to address these points.
Comment on lines
17
to
18
| API Reference | ||
| ------------- |
Contributor
There was a problem hiding this comment.
The API Reference header is duplicated. This can cause rendering issues in the generated documentation. Please remove this duplicated section.
Comment on lines
+202
to
+272
| __all__ = ( | ||
| "HypercomputeClusterAsyncClient", | ||
| "BootDisk", | ||
| "BucketReference", | ||
| "CheckClusterHealth", | ||
| "Cluster", | ||
| "ComputeInstance", | ||
| "ComputeInstanceSlurmNodeSet", | ||
| "ComputeResource", | ||
| "ComputeResourceConfig", | ||
| "CreateClusterRequest", | ||
| "CreateFilestoreInstance", | ||
| "CreateLoginNode", | ||
| "CreateLustreInstance", | ||
| "CreateNetwork", | ||
| "CreateNodeset", | ||
| "CreateOrchestrator", | ||
| "CreatePartition", | ||
| "CreatePrivateServiceAccess", | ||
| "CreateStorageBucket", | ||
| "DeleteClusterRequest", | ||
| "DeleteFilestoreInstance", | ||
| "DeleteLoginNode", | ||
| "DeleteLustreInstance", | ||
| "DeleteNetwork", | ||
| "DeleteNodeset", | ||
| "DeleteOrchestrator", | ||
| "DeletePartition", | ||
| "DeletePrivateServiceAccess", | ||
| "DeleteStorageBucket", | ||
| "ExistingBucketConfig", | ||
| "ExistingFilestoreConfig", | ||
| "ExistingLustreConfig", | ||
| "ExistingNetworkConfig", | ||
| "FileShareConfig", | ||
| "FilestoreReference", | ||
| "GcsAutoclassConfig", | ||
| "GcsHierarchicalNamespaceConfig", | ||
| "GetClusterRequest", | ||
| "HypercomputeClusterClient", | ||
| "ListClustersRequest", | ||
| "ListClustersResponse", | ||
| "LustreReference", | ||
| "NetworkReference", | ||
| "NetworkResource", | ||
| "NetworkResourceConfig", | ||
| "NewBucketConfig", | ||
| "NewFilestoreConfig", | ||
| "NewFlexStartInstancesConfig", | ||
| "NewLustreConfig", | ||
| "NewNetworkConfig", | ||
| "NewOnDemandInstancesConfig", | ||
| "NewReservedInstancesConfig", | ||
| "NewSpotInstancesConfig", | ||
| "OperationMetadata", | ||
| "OperationProgress", | ||
| "OperationStep", | ||
| "Orchestrator", | ||
| "SlurmLoginNodes", | ||
| "SlurmNodeSet", | ||
| "SlurmOrchestrator", | ||
| "SlurmPartition", | ||
| "StorageConfig", | ||
| "StorageResource", | ||
| "StorageResourceConfig", | ||
| "UpdateClusterRequest", | ||
| "UpdateLoginNode", | ||
| "UpdateNodeset", | ||
| "UpdateOrchestrator", | ||
| "UpdatePartition", | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and readability, the __all__ list should be sorted alphabetically.
__all__ = (
"BootDisk",
"BucketReference",
"CheckClusterHealth",
"Cluster",
"ComputeInstance",
"ComputeInstanceSlurmNodeSet",
"ComputeResource",
"ComputeResourceConfig",
"CreateClusterRequest",
"CreateFilestoreInstance",
"CreateLoginNode",
"CreateLustreInstance",
"CreateNetwork",
"CreateNodeset",
"CreateOrchestrator",
"CreatePartition",
"CreatePrivateServiceAccess",
"CreateStorageBucket",
"DeleteClusterRequest",
"DeleteFilestoreInstance",
"DeleteLoginNode",
"DeleteLustreInstance",
"DeleteNetwork",
"DeleteNodeset",
"DeleteOrchestrator",
"DeletePartition",
"DeletePrivateServiceAccess",
"DeleteStorageBucket",
"ExistingBucketConfig",
"ExistingFilestoreConfig",
"ExistingLustreConfig",
"ExistingNetworkConfig",
"FileShareConfig",
"FilestoreReference",
"GcsAutoclassConfig",
"GcsHierarchicalNamespaceConfig",
"GetClusterRequest",
"HypercomputeClusterAsyncClient",
"HypercomputeClusterClient",
"ListClustersRequest",
"ListClustersResponse",
"LustreReference",
"NetworkReference",
"NetworkResource",
"NetworkResourceConfig",
"NewBucketConfig",
"NewFilestoreConfig",
"NewFlexStartInstancesConfig",
"NewLustreConfig",
"NewNetworkConfig",
"NewOnDemandInstancesConfig",
"NewReservedInstancesConfig",
"NewSpotInstancesConfig",
"OperationMetadata",
"OperationProgress",
"OperationStep",
"Orchestrator",
"SlurmLoginNodes",
"SlurmNodeSet",
"SlurmOrchestrator",
"SlurmPartition",
"StorageConfig",
"StorageResource",
"StorageResourceConfig",
"UpdateClusterRequest",
"UpdateLoginNode",
"UpdateNodeset",
"UpdateOrchestrator",
"UpdatePartition",
)
Comment on lines
+88
to
+156
| __all__ = ( | ||
| "BootDisk", | ||
| "BucketReference", | ||
| "Cluster", | ||
| "ComputeInstance", | ||
| "ComputeInstanceSlurmNodeSet", | ||
| "ComputeResource", | ||
| "ComputeResourceConfig", | ||
| "CreateClusterRequest", | ||
| "DeleteClusterRequest", | ||
| "ExistingBucketConfig", | ||
| "ExistingFilestoreConfig", | ||
| "ExistingLustreConfig", | ||
| "ExistingNetworkConfig", | ||
| "FileShareConfig", | ||
| "FilestoreReference", | ||
| "GcsAutoclassConfig", | ||
| "GcsHierarchicalNamespaceConfig", | ||
| "GetClusterRequest", | ||
| "ListClustersRequest", | ||
| "ListClustersResponse", | ||
| "LustreReference", | ||
| "NetworkReference", | ||
| "NetworkResource", | ||
| "NetworkResourceConfig", | ||
| "NewBucketConfig", | ||
| "NewFilestoreConfig", | ||
| "NewFlexStartInstancesConfig", | ||
| "NewLustreConfig", | ||
| "NewNetworkConfig", | ||
| "NewOnDemandInstancesConfig", | ||
| "NewReservedInstancesConfig", | ||
| "NewSpotInstancesConfig", | ||
| "Orchestrator", | ||
| "SlurmLoginNodes", | ||
| "SlurmNodeSet", | ||
| "SlurmOrchestrator", | ||
| "SlurmPartition", | ||
| "StorageConfig", | ||
| "StorageResource", | ||
| "StorageResourceConfig", | ||
| "UpdateClusterRequest", | ||
| "CheckClusterHealth", | ||
| "CreateFilestoreInstance", | ||
| "CreateLoginNode", | ||
| "CreateLustreInstance", | ||
| "CreateNetwork", | ||
| "CreateNodeset", | ||
| "CreateOrchestrator", | ||
| "CreatePartition", | ||
| "CreatePrivateServiceAccess", | ||
| "CreateStorageBucket", | ||
| "DeleteFilestoreInstance", | ||
| "DeleteLoginNode", | ||
| "DeleteLustreInstance", | ||
| "DeleteNetwork", | ||
| "DeleteNodeset", | ||
| "DeleteOrchestrator", | ||
| "DeletePartition", | ||
| "DeletePrivateServiceAccess", | ||
| "DeleteStorageBucket", | ||
| "OperationMetadata", | ||
| "OperationProgress", | ||
| "OperationStep", | ||
| "UpdateLoginNode", | ||
| "UpdateNodeset", | ||
| "UpdateOrchestrator", | ||
| "UpdatePartition", | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and readability, the __all__ list should be sorted alphabetically.
__all__ = (
"BootDisk",
"BucketReference",
"CheckClusterHealth",
"Cluster",
"ComputeInstance",
"ComputeInstanceSlurmNodeSet",
"ComputeResource",
"ComputeResourceConfig",
"CreateClusterRequest",
"CreateFilestoreInstance",
"CreateLoginNode",
"CreateLustreInstance",
"CreateNetwork",
"CreateNodeset",
"CreateOrchestrator",
"CreatePartition",
"CreatePrivateServiceAccess",
"CreateStorageBucket",
"DeleteClusterRequest",
"DeleteFilestoreInstance",
"DeleteLoginNode",
"DeleteLustreInstance",
"DeleteNetwork",
"DeleteNodeset",
"DeleteOrchestrator",
"DeletePartition",
"DeletePrivateServiceAccess",
"DeleteStorageBucket",
"ExistingBucketConfig",
"ExistingFilestoreConfig",
"ExistingLustreConfig",
"ExistingNetworkConfig",
"FileShareConfig",
"FilestoreReference",
"GcsAutoclassConfig",
"GcsHierarchicalNamespaceConfig",
"GetClusterRequest",
"ListClustersRequest",
"ListClustersResponse",
"LustreReference",
"NetworkReference",
"NetworkResource",
"NetworkResourceConfig",
"NewBucketConfig",
"NewFilestoreConfig",
"NewFlexStartInstancesConfig",
"NewLustreConfig",
"NewNetworkConfig",
"NewOnDemandInstancesConfig",
"NewReservedInstancesConfig",
"NewSpotInstancesConfig",
"OperationMetadata",
"OperationProgress",
"OperationStep",
"Orchestrator",
"SlurmLoginNodes",
"SlurmNodeSet",
"SlurmOrchestrator",
"SlurmPartition",
"StorageConfig",
"StorageResource",
"StorageResourceConfig",
"UpdateClusterRequest",
"UpdateLoginNode",
"UpdateNodeset",
"UpdateOrchestrator",
"UpdatePartition",
)
daniel-sanche
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to onboard a new Cloud Client Library.
BEGIN_COMMIT
feat: onboard a new library
PiperOrigin-RevId: 873108574
Library-IDs: google-cloud-hypercomputecluster
END_COMMIT
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c