feat: Enable multi-column sorting in anywidget mode #2360
+262
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c39293a.
… be displayed in one page
…t _literal (#2337) This change can resolve two doctests failures in #2248: `groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve` Fixes internal issue 417774347🦕 --------- Co-authored-by: Shenyang Cai <[email protected]>
This reverts commit 593f9ae.
…and fix mypy errors
- Replaced RLock with Lock in TableWidget for a stricter threading model. - Refactored _set_table_html to defer state updates (specifically self.page) until the lock is released. - This ensures that when a page update triggers an observer, the subsequent re-entry into _set_table_html is not nested within the original lock's scope, avoiding deadlocks. - Added a targeted unit test to verify that navigating to an invalid page correctly resets to a valid page without deadlocking.
- Added a mock fallback for 'traitlets' in bigframes/display/anywidget.py to avoid NameError during class definition when the package is not installed. - Moved 'pytest.importorskip' calls in tests/unit/display/test_anywidget.py to the top to ensure tests are skipped before attempting any imports from the module under test. - Added noqa: E402 to suppress flake8 warnings for imports after importorskip.
…cies missing - Reverted changes to bigframes/display/anywidget.py to keep source code clean (no mock injection). - Refactored tests/unit/display/test_anywidget.py to avoid top-level import of bigframes.display.anywidget. - Imported TableWidget inside the test method, ensuring pytest.importorskip runs first and skips the test file if dependencies are missing, preventing the NameError crash.
- Refactored test_navigation_to_invalid_page_resets_to_valid_page_without_deadlock to follow established project conventions. - Use internal import from bigframes.display.anywidget. - Employ bigframes.option_context for setting widget state. - Improved docstring to follow behavior-driven (Given/When/Then) style.
# Conflicts: # bigframes/display/html.py
Updates the TableWidget to support sorting by multiple columns. - Python: Changes sort_column/sort_ascending traits to lists. - JS: Adds Shift+Click support for multi-column sorting. - JS: Displays sort indicators for all sorted columns. - Tests: Adds unit tests for multi-column sorting logic.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings multi-column sorting capabilities to the interactive DataFrame display (anywidget mode), allowing for more powerful data exploration directly within our notebook.
What's New:
How to use:
Fixes #<459835971> 🦕