Conversation
Manifest.findMergedReleasePullRequests parses the merged release PR body once, then calls toString() on the result and hands that string to every Strategy.buildRelease, which parses it a second time. extractMultipleReleases read each section's notes with textContent, which decodes htmlEscape's `<`/`>` back into a raw `<word>`. That raw tag survives into the reserialised body and breaks the second HTML parse, silently dropping whichever `<details>` section contains it (and any later sections nested inside it). Read the notes with innerHTML instead: it preserves release-please's own escaping verbatim, so it round-trips through both parses without corrupting the DOM. Fixes googleapis#2899 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest.findMergedReleasePullRequests parses the merged release PR body once, then calls toString() on the result and hands that string to every Strategy.buildRelease, which parses it a second time. extractMultipleReleases read each section's notes with textContent, which decodes htmlEscape's
</>back into a raw<word>. That raw tag survives into the reserialised body and breaks the second HTML parse, silently dropping whichever<details>section contains it (and any later sections nested inside it).Read the notes with innerHTML instead: it preserves release-please's own escaping verbatim, so it round-trips through both parses without corrupting the DOM.
Fixes #2899
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕