graph, runtime: Do not panic when converting negative number to U256 #6219
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isum
approved these changes
Dec 2, 2025
isum
reviewed
Dec 2, 2025
| self | ||
| ); | ||
| U256::from_little_endian(&bytes) | ||
| if sign != BigIntSign::Plus && sign != BigIntSign::NoSign { |
Member
There was a problem hiding this comment.
A Minus variant is available. It may be clearer to use it
Suggested change
| if sign != BigIntSign::Plus && sign != BigIntSign::NoSign { | |
| if BigIntSign::Minus { |
Return an error instead
lutter
force-pushed
the
lutter/uint-err
branch
from
e849acf to
44b5638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error instead