Skip to content

fix cloudflare pages(?)#40

Open
magicmark wants to merge 2 commits into
mainfrom
magicmark-patch-6
Open

fix cloudflare pages(?)#40
magicmark wants to merge 2 commits into
mainfrom
magicmark-patch-6

Conversation

@magicmark
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gaps e6f6f97 Commit Preview URL

Branch Preview URL
May 23 2026, 12:53 AM

@magicmark
Copy link
Copy Markdown
Contributor Author

This seems like the correct way to do it.

When I tried enabling cloudflare with a personal account on a copy of this repo, it actually robogenerated this PR magicmark/gaps-website-test-1#1

with this message:

Screenshot 2026-05-22 at 7 52 46 PM

by the by, I was surprised/concerned that this PR would be able to affect what cloudflare does (since it's not on main) but I guess that's intentional. The security model is that it only runs on non-fork PRs....which means deploy previews don't work like they do with vercel. didn't realize this, hrmph.

i guess we could build something custom but was hoping not to have to maintain infra, hoping it would work out the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant