Skip to content

Add radio configuration update callback#1689

Merged
mossmann merged 3 commits intomainfrom
radio-config-callback
Apr 16, 2026
Merged

Add radio configuration update callback#1689
mossmann merged 3 commits intomainfrom
radio-config-callback

Conversation

@mossmann
Copy link
Copy Markdown
Member

@mossmann mossmann commented Feb 25, 2026 •
edited
Loading

Depends on #1708

A new callback replaces and centralizes UI and Opera Cake update calls scattered throughout the code.

@mossmann
Copy link
Copy Markdown
Member Author

mossmann commented Feb 25, 2026

I believe that the blinky build is failing due to an include dependency problem. I'll see if #1657 solves it.

@mossmann mossmann force-pushed the radio-config-callback branch 3 times, most recently from 347f717 to a2dac85 Compare March 3, 2026 17:40
@mossmann
Copy link
Copy Markdown
Member Author

mossmann commented Mar 5, 2026

The blinky build was actually failing because I shouldn't have put the new function into hackrf_core.c. I moved it to hackrf_usb.c.

@mossmann mossmann force-pushed the radio-config-callback branch from a2dac85 to bf66f72 Compare March 10, 2026 17:38
@mossmann mossmann marked this pull request as ready for review March 10, 2026 18:03
@mossmann mossmann requested a review from antoinevg March 10, 2026 18:03
antoinevg
antoinevg requested changes Mar 12, 2026
View reviewed changes
Comment thread firmware/common/hackrf_core.c
@mossmann mossmann force-pushed the radio-config-callback branch from bf66f72 to 55ae863 Compare March 12, 2026 15:47
@mossmann mossmann requested a review from antoinevg March 12, 2026 17:12
antoinevg
antoinevg approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@antoinevg antoinevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

martinling
martinling requested changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@martinling martinling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently breaks the built-in portapack UI.

E.g. hackrf_transfer -r mostly displays correctly but is missing the received wave symbol by the antenna. Subsequently, hackrf_transfer -t does not change the display.

@martinling martinling force-pushed the radio-config-callback branch from d4cdaea to a9ec353 Compare March 13, 2026 16:28
@martinling
Copy link
Copy Markdown
Member

martinling commented Mar 13, 2026

I figured out what was going wrong and have pushed fixes to this branch.

@mossmann
Copy link
Copy Markdown
Member Author

mossmann commented Mar 13, 2026

@martinling Thank you! I believe I had fixed both those problems previously but somehow lost my fixes.

@martinling
Copy link
Copy Markdown
Member

martinling commented Mar 13, 2026

I'd thought with that logic fixed that #1697 might work, but that's now differently broken.

@mossmann mossmann marked this pull request as draft March 16, 2026 20:49
@mossmann mossmann force-pushed the radio-config-callback branch from a9ec353 to c3deb84 Compare March 16, 2026 21:00
@mossmann
Copy link
Copy Markdown
Member Author

mossmann commented Mar 16, 2026

I incorporated @martinling's changes, fixed some additional bugs, and rebased. I set this back to draft because I found an additional bug that is not yet fixed:

The PortaPack UI does not correctly display the image reject filter state. This is because the radio configuration registers do not yet store the applied image reject filter state. I have some work in progress that stores this and other tuning registers, but it needs some work to bring up to date with main. I think it would be best to finish that work and merge it before this.

@mossmann mossmann mentioned this pull request Mar 17, 2026
Open
@mossmann mossmann force-pushed the radio-config-callback branch from c3deb84 to cb5fe35 Compare March 31, 2026 15:07
@mossmann mossmann mentioned this pull request Apr 9, 2026
Merged
@mossmann mossmann force-pushed the radio-config-callback branch from cb5fe35 to 3a25025 Compare April 9, 2026 23:28
@mossmann mossmann marked this pull request as ready for review April 10, 2026 12:31
@mossmann mossmann marked this pull request as draft April 10, 2026 22:12
@mossmann mossmann force-pushed the radio-config-callback branch 2 times, most recently from ffcac3f to 08fc5c6 Compare April 13, 2026 22:14
This was referenced Apr 13, 2026
Closed
Open
mossmann and others added 3 commits April 14, 2026 13:35
@mossmann
Ensure correct gains displayed in PortaPack UI
59e8670 
Previously it was possible, though rare, for an update of an RX gain
setting to be displayed during TX mode or for an update of a TX gain
setting to be displayed during RX mode.
@mossmann @martinling
Add radio configuration update callback
5728550 
Co-authored-by: Martin Ling <martin-git@earth.li>
@martinling @mossmann
Move sgpio_configure calls to radio_changed callback.
43454dd
@mossmann mossmann force-pushed the radio-config-callback branch from 08fc5c6 to 43454dd Compare April 14, 2026 17:36
@mossmann
Copy link
Copy Markdown
Member Author

mossmann commented Apr 14, 2026

The required storage of image reject filter state was implemented in #1708.

@mossmann mossmann requested a review from martinling April 14, 2026 18:01
@mossmann mossmann marked this pull request as ready for review April 14, 2026 18:20
@mossmann mossmann merged commit da017d7 into main Apr 16, 2026
84 checks passed
@mossmann mossmann deleted the radio-config-callback branch April 16, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoinevg antoinevg antoinevg approved these changes

@martinling martinling martinling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mossmann @martinling @antoinevg