Skip to content

Re-enable Activity in config panel#269

Closed
everettbu wants to merge 1 commit intomainfrom
reenable-activity-config-panel
Closed

Re-enable Activity in config panel#269
everettbu wants to merge 1 commit intomainfrom
reenable-activity-config-panel

Conversation

@everettbu
Copy link
Copy Markdown

Mirror of facebook/react#35401
Original author: afurm


  • Summary: Restore <Activity> wrappers around the config panel’s expanded/collapsed views in compiler/apps/playground/components/Editor/ConfigEditor.tsx after the Next.js upgrade.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Dec 21, 2025

Greptile Summary

This PR restores the <Activity> component wrappers around the config panel's expanded and collapsed views, which were temporarily disabled during a Next.js downgrade for security reasons. Now that Next.js has been upgraded to version 15.5.9, the <Activity> components can be safely re-enabled.

The change replaces temporary div elements with inline display styles with proper <Activity mode> wrappers that provide better integration with React's view transition system. The implementation correctly uses:

  • <Activity mode={isExpanded ? 'visible' : 'hidden'}> for the expanded editor
  • <Activity mode={isExpanded ? 'hidden' : 'visible'}> for the collapsed editor

This ensures proper visibility toggling coordinated with the config panel transitions.

Confidence Score: 5/5

  • This PR is safe to merge with no identified risks
  • The change is a straightforward restoration of previously working code that was temporarily disabled. The Activity component is properly exported from React 19.2.3, Next.js has been upgraded to 15.5.9 (addressing the security concerns that caused the temporary removal), and the implementation follows the exact pattern that was used before. The logic is simple and correct - toggling between two mutually exclusive states with proper visibility controls.
  • No files require special attention

Important Files Changed

Filename Overview
compiler/apps/playground/components/Editor/ConfigEditor.tsx Restored <Activity> wrappers around expanded/collapsed views after Next.js upgrade, replacing temporary div workaround

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions Bot added the Resolution: Stale Automatically closed due to inactivity label Mar 21, 2026
@github-actions
Copy link
Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions Bot closed this Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Resolution: Stale Automatically closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants