Skip to content

harmonize translation keys - #197

Merged
achour94 merged 6 commits into
mainfrom
chore_normalize_translation
Aug 3, 2026
Merged

harmonize translation keys#197
achour94 merged 6 commits into
mainfrom
chore_normalize_translation

Conversation

@JacquesBorsenberger

Copy link
Copy Markdown
Contributor

PR Summary

use commons keys and constant for commons translations (depends on commons-ui PR)

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8e584f8-13ef-4be7-b2fb-64d68c831c69

📥 Commits

Reviewing files that changed from the base of the PR and between e9cecb7 and 9afc1e4.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Modification schemas now use shared validation constants. Profile quota fields use a reusable validation schema. AppWrapper loads generic English and French validation messages, and local YupRequired entries are removed.

Changes

Validation message consistency

Layer / File(s) Summary
Shared validation contracts
package.json, src/utils/translation-keys.ts, src/pages/profiles/modification/profile-modification-dialog.tsx
The commons UI dependency is updated. The profile dialog imports shared validation constants and defines the USER_QUOTA_POSITIVE translation key.
Modification schema validation
src/pages/groups/modification/group-modification-form.tsx, src/pages/profiles/modification/profile-modification-dialog.tsx, src/pages/users/modification/user-modification-form.tsx
Group, profile, and user schemas use shared required-name messages. Profile quota fields use a reusable required and positive-number schema.
Validation catalog integration
src/components/App/AppWrapper.tsx, src/translations/en.json, src/translations/fr.json
AppWrapper merges English and French generic validation messages into the Intl catalogs. Local YupRequired entries are removed from both translation files.

Suggested reviewers: achour94, themaskedturtle, thangqp

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: harmonizing translation keys and shared constants.
Description check ✅ Passed The description directly relates to using shared commons translation keys and constants.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/users/modification/user-modification-form.tsx`:
- Around line 11-12: Merge the duplicate `@gridsuite/commons-ui` imports in the
user modification form into a single declaration containing AutocompleteInput,
NAME_EMPTY, snackWithFallback, TextInput, and useSnackMessage; preserve all
existing imported symbols.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ea746b33-e32b-411d-ba4c-48ad5cb763d4

📥 Commits

Reviewing files that changed from the base of the PR and between 9341178 and ae5168b.

📒 Files selected for processing (3)
  • src/pages/groups/modification/group-modification-form.tsx
  • src/pages/profiles/modification/profile-modification-dialog.tsx
  • src/pages/users/modification/user-modification-form.tsx

Comment thread src/pages/users/modification/user-modification-form.tsx Outdated

@achour94 achour94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. Spread genericValidationEn/Fr in AppWrapper.tsx (both languages).
  2. Then remove the duplicated nameEmpty and YupRequired entries from en.json/fr.json.

achour94 added 2 commits July 31, 2026 20:25
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@achour94
achour94 merged commit ff4190c into main Aug 3, 2026
5 checks passed
@achour94
achour94 deleted the chore_normalize_translation branch August 3, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants