harmonize translation keys - #197
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModification schemas now use shared validation constants. Profile quota fields use a reusable validation schema. ChangesValidation message consistency
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/users/modification/user-modification-form.tsx`:
- Around line 11-12: Merge the duplicate `@gridsuite/commons-ui` imports in the
user modification form into a single declaration containing AutocompleteInput,
NAME_EMPTY, snackWithFallback, TextInput, and useSnackMessage; preserve all
existing imported symbols.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ea746b33-e32b-411d-ba4c-48ad5cb763d4
📒 Files selected for processing (3)
src/pages/groups/modification/group-modification-form.tsxsrc/pages/profiles/modification/profile-modification-dialog.tsxsrc/pages/users/modification/user-modification-form.tsx
achour94
left a comment
There was a problem hiding this comment.
Please:
- Spread genericValidationEn/Fr in AppWrapper.tsx (both languages).
- Then remove the duplicated nameEmpty and YupRequired entries from en.json/fr.json.
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
|



PR Summary
use commons keys and constant for commons translations (depends on commons-ui PR)