Add Privacy/Terms link to Sign in page#1109
Open
matmanna wants to merge 2 commits intohackclub:mainfrom
Open
Conversation
Contributor
Greptile SummaryThis PR makes two small UI changes to the sign-in page: it updates the subtitle copy from "coding time" to "hacking time," and adds a privacy policy/terms consent notice that links to
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User visits /sign_in] --> B[SignIn.svelte renders]
B --> C[Logo + Title + Subtitle]
C --> D[AuthForm: HCA / Slack / Email]
D --> E["← Back to home link"]
E --> F["✨ NEW: Privacy policy & terms link\n(https://hackclub.com/privacy)"]
Prompt To Fix All With AIThis is a comment left during a code review.
Path: app/javascript/pages/Auth/SignIn.svelte
Line: 88-90
Comment:
**Indentation inconsistency**
The new `<p>` element is indented with 6 spaces, while its sibling `<div class="text-center">` elements are at 4 spaces. It also should probably be wrapped in a `text-center` div (or have `text-center` on the `<p>` itself) for consistency with the rest of the page, since the parent flex container's `items-center` only centers the block, not the text within it.
```suggestion
<div class="text-center">
<p class="text-secondary text-sm">
By signing in, you agree to the Hack Club <a class="text-primary" href="https://hackclub.com/privacy">privacy policy and terms</a>.
</p>
</div>
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat: add privacy&terms warning to signi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While already linked in the hackatime landing page's footer, I think this makes it clearer at the time of authentication that Hackatime is considered a "Hack Club Service" per the Privacy Policy / Terms and Conditions. This also matches how HCA presents this link in its own auth pages.
Before:
After:
