Skip to content

chore: update schema excel template with the missing field types - #6908

Open
ihar-tsykala wants to merge 4 commits into
developfrom
feat/update-the-excel-template-with-new-properties
Open

ihar-tsykala wants to merge 4 commits into
developfrom
feat/update-the-excel-template-with-new-properties

Conversation

@ihar-tsykala

@ihar-tsykala ihar-tsykala commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description:

The schema template offered on the Policy Schemas page no longer worked. It failed its own import, and it was out of date — it listed 22 field types while Guardian accepts 27, so anyone starting from it had no way to know the newer types existed.

This updates the template workbook. It imports again, it covers every supported field type with a worked example, its README matches what the importer actually does, and the example descriptions now read as the labels a user sees on the form. A unit test parses the committed file so it cannot drift out of date again unnoticed.

No product code changed — every field type already worked. Only the template and one test file are touched.

Fixes #

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ihar-tsykala ihar-tsykala self-assigned this Sep 11, 2026
@ihar-tsykala
ihar-tsykala requested review from a team as code owners September 11, 2026 21:58
@ihar-tsykala
ihar-tsykala marked this pull request as draft September 11, 2026 21:58
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

Test Results

 33 files  ±0   66 suites  ±0   3m 18s ⏱️ ±0s
 35 tests ±0   35 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5190353. ± Comparison against base commit c9f1b12.

♻️ This comment has been updated with latest results.

@swidnikk

Copy link
Copy Markdown
Contributor

Couple things I've noticed

Enum worksheet: remove the Schema Name Column

The Enums sheet's "Schema name" column is dead weight — readSharedEnumSheet/resolveSharedEnumColumns in common/src/xlsx/xlsx-to-json.ts match headers by name (Enum Name, Loaded to IPFS, Value) and never read a "Schema name" column; enums are matched globally by name, not scoped per schema. Keeping it in the template implies authors should fill it in, but it's just unused overhead. Suggest dropping it from the template/README so the example matches what the parser actually consumes: Enum Name | Loaded to IPFS | Value.

Update the guidance for Enum's

In the Enums tab, the three columns are: Enum Name | Loaded to IPFS | Value

For the first value of each group: fill in Enum Name, Loaded to IPFS. Leave those three columns blank on subsequent value rows for the same group.

Dropdown list — values defined in the Enums tab. The field's Parameter must exactly match the "Enum Name" column.

Parameter column: Type-dependent: enum name (Enum)

image

Description Examples

Suggest to update all description fields to represent what might be presented to the user on a form such as the following,
image

@ihar-tsykala
ihar-tsykala marked this pull request as ready for review September 22, 2026 20:45
@ihar-tsykala

Copy link
Copy Markdown
Contributor Author

Hey @swidnikk, could you check it again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants