Open
Conversation
Author
|
It turns out that this is not really what I want. Ultimately I want to produce a servant stream, using its SourceT / StepT types. This means I need a right fold, not a left fold. Right folds are awkward as an API because there is no guarantee that the combining function actually consumes all of the results. Not consuming all results means the connection is left in a bad state where the next query will complain that another command is already in progress. (This isn't that different from trying to execute another query in the combining function of a left fold, but it does seem worse somehow.) If anyone has any clever ideas, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a version of
foldWiththat uses single row mode instead of a cursor under the hood.The main benefit is that queries show up as themselves in logs and pg_stat_statements and the like (c.f., #100).
This PR doesn't yet define
foldSingleRowModeandfoldSingleRowMode_(the versions usingFromRowrather than an explicit parser). I'd be happy to add them or instead add aSingleRowModeconstructor toFoldOptions. (Mild preference for the extra functions.)