Skip to content

test(sanity): make ChannelPage.sendMention's retry loop reachable #11013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clayrisser wants to merge 1 commit into from
Closed

test(sanity): make ChannelPage.sendMention's retry loop reachable #11013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/sanity/tests/model/channel-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ export class ChannelPage extends CommonPage {
for (let i = 0; i < 3; i++) {
try {
await this.inputMessage().fill(`@${message}`)
await this.selectMention(message, categoryName)
// An explicit timeout is required: the suite sets no `actionTimeout`, so the
// default click would wait out the whole test timeout and the retries below
// would never run.
await this.mentionPopupListItem(message, categoryName).first().click({ timeout: 5000 })
break
} catch (error: any) {
if (i === 2) {
Expand Down