Skip to content

fix(models): give drive a PluginConfiguration so it can be disabled safely #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clayrisser wants to merge 1 commit into from
Closed

fix(models): give drive a PluginConfiguration so it can be disabled safely #11017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions models/all/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import contact, { contactId, createModel as contactModel } from '@hcengineering/
import { createModel as coreModel } from '@hcengineering/model-core'
import { desktopDownloadsId, createModel as desktopDownloadsModel } from '@hcengineering/model-desktop-downloads'
import { desktopPreferencesId, createModel as desktopPreferencesModel } from '@hcengineering/model-desktop-preferences'
import { driveId, createModel as driveModel } from '@hcengineering/model-drive'
import drive, { driveId, createModel as driveModel } from '@hcengineering/model-drive'
import gmail, { gmailId, createModel as gmailModel } from '@hcengineering/model-gmail'
import { guestId, createModel as guestModel } from '@hcengineering/model-guest'
import hr, { hrId, createModel as hrModel } from '@hcengineering/model-hr'
Expand Down Expand Up @@ -413,7 +413,23 @@ export default function buildModel (): Builder {
classFilter: defaultFilter
}
],
[driveModel, driveId],
// Without a config entry classFilter is undefined, which makes DISABLED_FEATURES=drive
// strip drive's ENTIRE client model — class definitions included — and every consumer
// that still resolves a drive class (Inbox DocNotifyContexts, the recorder save flow,
// doc embeds of drive files) throws out of Hierarchy.getClass/getDomain. Filtering to
// the two doc classes drive actually contributes to the shared UI surfaces hides the
// app and its search categories while leaving the classes intact.
[
driveModel,
driveId,
{
label: drive.string.Drive,
enabled: true,
beta: false,
icon: drive.icon.DriveApplication,
classFilter: [workbench.class.Application, presentation.class.ObjectSearchCategory]
}
],
[
documentsModel,
documentsId,
Expand Down