Repository navigation
Fix login redirects and password hash column capacity - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anonymous requests to protected views currently fail with a
BuildError: Flask-Login targetslogin, but the blueprint registersauth.login. Pointlogin_viewat the registered endpoint so/settingsredirects to/login?next=%2Fsettingsand renders the login form.The pinned Werkzeug version also generates 162-character password hashes, exceeding the model's
String(128)declaration. Widen it toString(256). SQLite accepts the longer values, which hid this schema mismatch; databases enforcing the declared length need enough capacity. This model change does not migrate existing databases.Add regressions for the complete anonymous redirect and for generated hashes fitting the declared column while validating correct and incorrect passwords. Both tests fail on the original code and pass with these changes.
Validation:
init-db,init-db --drop,admincreation/update, andforge.