Skip to content

CASL-1784 gradle build fix#576

Merged
piotrhere merged 6 commits into
v3from
v3_CASL-1784_fix_gradle_build
May 12, 2026
Merged

CASL-1784 gradle build fix#576
piotrhere merged 6 commits into
v3from
v3_CASL-1784_fix_gradle_build

Conversation

@piotrhere
Copy link
Copy Markdown

A successful pipeline run of a tag created out of this branch: https://main.gitlab.in.here.com/wall-e/common/cloud-architecture-2/naksha/devops/naksha-pipeline/-/pipelines/29475029/

Currently we need the following env variables to execute the gradle build tests against a standalone Postgres image:

NAKSHA_TEST_ADMIN_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_TEST_PSQL_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_TEST_DATA_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_APP_SERVICE_TEST_CONTEXT=LOCAL_STANDALONE
NAKSHA_TEST_STORAGE_ID=local_psql_test_storage
HUB_ADMIN_STORAGE_ID=local_psql_test_storage

Task to simplify the setup to minimize the number of variables: https://here-technologies.atlassian.net/browse/CASL-1796

…env variable

Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Code Coverage

Overall Project 62.94% -0.01% 🍏
Files changed 78.46% 🍏

File Coverage
NakshaHubAdminStorageIdentifiers.java 66.67% -33.33% 🍏
NakshaHub.java 38.19% 🍏

@piotrhere piotrhere requested a review from hirenkp2000 May 5, 2026 08:25
}
}

setOverallCoverage(0.0) // only increasing allowed!
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting coverage is not needed, considering it has only utils and no real test.

@hirenkp2000
Copy link
Copy Markdown
Member

A successful pipeline run of a tag created out of this branch: https://main.gitlab.in.here.com/wall-e/common/cloud-architecture-2/naksha/devops/naksha-pipeline/-/pipelines/29475029/

Currently we need the following env variables to execute the gradle build tests against a standalone Postgres image:

NAKSHA_TEST_ADMIN_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_TEST_PSQL_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_TEST_DATA_DB_URL="jdbc:postgresql://postgres:5432/postgres?user=postgres&password=password"
NAKSHA_APP_SERVICE_TEST_CONTEXT=LOCAL_STANDALONE
NAKSHA_TEST_STORAGE_ID=local_psql_test_storage
HUB_ADMIN_STORAGE_ID=local_psql_test_storage

Task to simplify the setup to minimize the number of variables: https://here-technologies.atlassian.net/browse/CASL-1796

Caution for future - avoid putting any HERE internal links anywhere in OSS repo.

import kotlin.jvm.JvmStatic

object CommonTestConstants {
private const val DEFAULT_TEST_STORAGE_ID: String = "local_psql_test_storage"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carried an understanding that use of different storageId was the problem, but I still find two storageId in use (i.e. local_psql_test_storage and naksha-hub-admin-storage). I wonder, how this works, when we still use the same Postgres DB instance.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The understanding is correct, we need a single storageId for the whole build.

Currently it’s local_psql_test_storage. The naksha-hub-admin-storage is internal to Hub only, and now it’s overridable - during the build it’s also set to local_psql_test_storage.
I recall we initially agreed on simply reusing naksha-hub-admin-storage everywhere, but if with minimal effort we could set it to any arbitrary value, I went with this approach.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that clarifies. And I see the README is also updated to avoid this confusion. Thanks.

Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Code Coverage

Overall Project 62.92% -0.01% 🍏
Files changed 78.46% 🍏

File Coverage
NakshaHubAdminStorageIdentifiers.java 66.67% -33.33% 🍏
NakshaHub.java 38.19% 🍏

Comment thread README.md
Comment thread README.md
gunplar
gunplar previously approved these changes May 8, 2026
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
@github-actions
Copy link
Copy Markdown

Code Coverage

Overall Project 62.91% -0.01% 🍏
Files changed 83.53% 🍏

File Coverage
NakshaHubAdminStorageIdentifiers.java 66.67% -33.33% 🍏
NakshaHub.java 38.6% 🍏

@github-actions
Copy link
Copy Markdown

Code Coverage

Overall Project 62.94% -0.01% 🍏
Files changed 83.53% 🍏

File Coverage
NakshaHubAdminStorageIdentifiers.java 66.67% -33.33% 🍏
NakshaHub.java 38.6% 🍏

@piotrhere piotrhere merged commit 6e2c116 into v3 May 12, 2026
3 checks passed
@piotrhere piotrhere deleted the v3_CASL-1784_fix_gradle_build branch May 12, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants