CASL-1784 gradle build fix#576
Conversation
…env variable Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Code Coverage
|
| } | ||
| } | ||
|
|
||
| setOverallCoverage(0.0) // only increasing allowed! |
There was a problem hiding this comment.
I think setting coverage is not needed, considering it has only utils and no real test.
Caution for future - avoid putting any HERE internal links anywhere in OSS repo. |
| import kotlin.jvm.JvmStatic | ||
|
|
||
| object CommonTestConstants { | ||
| private const val DEFAULT_TEST_STORAGE_ID: String = "local_psql_test_storage" |
There was a problem hiding this comment.
I carried an understanding that use of different storageId was the problem, but I still find two storageId in use (i.e. local_psql_test_storage and naksha-hub-admin-storage). I wonder, how this works, when we still use the same Postgres DB instance.
There was a problem hiding this comment.
The understanding is correct, we need a single storageId for the whole build.
Currently it’s local_psql_test_storage. The naksha-hub-admin-storage is internal to Hub only, and now it’s overridable - during the build it’s also set to local_psql_test_storage.
I recall we initially agreed on simply reusing naksha-hub-admin-storage everywhere, but if with minimal effort we could set it to any arbitrary value, I went with this approach.
There was a problem hiding this comment.
Ok, that clarifies. And I see the README is also updated to avoid this confusion. Thanks.
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Code Coverage
|
Signed-off-by: Piotr-Here <ext-piotr.sobotowski@here.com>
Code Coverage
|
…_build # Conflicts: # build.gradle.kts
Code Coverage
|
A successful pipeline run of a tag created out of this branch: https://main.gitlab.in.here.com/wall-e/common/cloud-architecture-2/naksha/devops/naksha-pipeline/-/pipelines/29475029/
Currently we need the following env variables to execute the gradle build tests against a standalone Postgres image:
Task to simplify the setup to minimize the number of variables: https://here-technologies.atlassian.net/browse/CASL-1796