Skip to content

refactor(acpi): migrate to arch-independent acpi crate - #2650

Open
mkroening wants to merge 5 commits into
mainfrom
acpi-crate
Open

refactor(acpi): migrate to arch-independent acpi crate#2650
mkroening wants to merge 5 commits into
mainfrom
acpi-crate

Conversation

@mkroening

@mkroening mkroening commented Aug 16, 2026

Copy link
Copy Markdown
Member

@mkroening mkroening self-assigned this Aug 16, 2026
@mkroening mkroening linked an issue Aug 16, 2026 that may be closed by this pull request
@mkroening mkroening changed the title refactor: migrate to arch-independent acpi crate refactor(acpi): migrate to arch-independent acpi crate Aug 19, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 98d2666 Previous: 2e23902 Performance Ratio
startup_benchmark Build Time 89.17 s 80.34 s 1.11
startup_benchmark File Size 0.85 MB 0.80 MB 1.07
Startup Time - 1 core 0.74 s (±0.02 s) 0.75 s (±0.02 s) 1.00
Startup Time - 2 cores 0.74 s (±0.03 s) 0.74 s (±0.02 s) 1.00
Startup Time - 4 cores 0.74 s (±0.03 s) 0.74 s (±0.02 s) 1.00
multithreaded_benchmark Build Time 89.07 s 82.11 s 1.08
multithreaded_benchmark File Size 0.91 MB 0.86 MB 1.06
Multithreaded Pi Efficiency - 2 Threads 91.41 % (±8.52 %) 85.89 % (±6.61 %) 1.06
Multithreaded Pi Efficiency - 4 Threads 45.00 % (±3.08 %) 43.43 % (±2.56 %) 1.04
Multithreaded Pi Efficiency - 8 Threads 25.96 % (±1.10 %) 25.76 % (±1.53 %) 1.01
micro_benchmarks Build Time 86.18 s 80.40 s 1.07
micro_benchmarks File Size 0.91 MB 0.86 MB 1.06
Scheduling time - 1 thread 62.72 ticks (±3.08 ticks) 62.65 ticks (±4.06 ticks) 1.00
Scheduling time - 2 threads 33.67 ticks (±2.31 ticks) 34.08 ticks (±4.10 ticks) 0.99
Micro - Time for syscall (getpid) 3.81 ticks (±0.54 ticks) 3.45 ticks (±0.58 ticks) 1.10
Memcpy speed - (built_in) block size 4096 79029.25 MByte/s (±54842.61 MByte/s) 82448.38 MByte/s (±56997.13 MByte/s) 0.96
Memcpy speed - (built_in) block size 1048576 29922.61 MByte/s (±24203.36 MByte/s) 30585.98 MByte/s (±24707.84 MByte/s) 0.98
Memcpy speed - (built_in) block size 16777216 28185.65 MByte/s (±23181.33 MByte/s) 26340.06 MByte/s (±21720.96 MByte/s) 1.07
Memset speed - (built_in) block size 4096 79327.61 MByte/s (±55016.77 MByte/s) 82292.76 MByte/s (±56891.50 MByte/s) 0.96
Memset speed - (built_in) block size 1048576 30619.62 MByte/s (±24609.69 MByte/s) 31323.85 MByte/s (±25145.86 MByte/s) 0.98
Memset speed - (built_in) block size 16777216 28901.04 MByte/s (±23582.84 MByte/s) 27104.68 MByte/s (±22209.94 MByte/s) 1.07
Memcpy speed - (rust) block size 4096 72230.40 MByte/s (±50807.72 MByte/s) 74097.96 MByte/s (±51811.44 MByte/s) 0.97
Memcpy speed - (rust) block size 1048576 29945.97 MByte/s (±24261.42 MByte/s) 30361.60 MByte/s (±24602.37 MByte/s) 0.99
Memcpy speed - (rust) block size 16777216 28225.89 MByte/s (±23226.24 MByte/s) 27625.34 MByte/s (±22806.88 MByte/s) 1.02
Memset speed - (rust) block size 4096 72716.23 MByte/s (±51088.92 MByte/s) 74373.47 MByte/s (±51976.48 MByte/s) 0.98
Memset speed - (rust) block size 1048576 30698.15 MByte/s (±24676.53 MByte/s) 31110.89 MByte/s (±25033.24 MByte/s) 0.99
Memset speed - (rust) block size 16777216 28947.94 MByte/s (±23627.80 MByte/s) 28386.93 MByte/s (±23265.03 MByte/s) 1.02
alloc_benchmarks Build Time 86.02 s 74.76 s 1.15
alloc_benchmarks File Size 0.93 MB 0.87 MB 1.06
Allocations - Allocation success 91.37 % 91.31 % 1.00
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 61.61 % 61.44 % 1.00
Allocations - Average Allocation time 4054.71 Ticks (±988.00 Ticks) 5860.58 Ticks (±98.43 Ticks) 0.69
Allocations - Average Allocation time (no fail) 5014.45 Ticks (±890.03 Ticks) 6554.81 Ticks (±92.86 Ticks) 0.77
Allocations - Average Deallocation time 1616.72 Ticks (±392.35 Ticks) 1805.01 Ticks (±250.35 Ticks) 0.90
mutex_benchmark Build Time 115.15 s 79.82 s 1.44
mutex_benchmark File Size 0.91 MB 0.86 MB 1.06
Mutex Stress Test Average Time per Iteration - 1 Threads 12.98 ns (±0.62 ns) 12.10 ns (±0.41 ns) 1.07
Mutex Stress Test Average Time per Iteration - 2 Threads 73.24 ns (±2.87 ns) 40.26 ns (±1.68 ns) 1.82

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening

Copy link
Copy Markdown
Member Author

I have dropped the AML interpreter, which is too slow and too large for our kernel stack without optimizations (cc5cb7a).

@mkroening
mkroening marked this pull request as ready for review September 6, 2026 18:03
@mkroening
mkroening requested a review from stlankes September 6, 2026 18:04
@mkroening mkroening assigned stlankes and unassigned mkroening Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to the acpi crate for ACPI handling

2 participants