Merged
Conversation
hexagonal-sun
requested changes
Jan 13, 2026
arihant2math
force-pushed
the
rwlock
branch
5 times, most recently
from
e3c8f6e to
20a6b0a
Compare
hexagonal-sun
requested changes
Feb 15, 2026
arihant2math
force-pushed
the
rwlock
branch
8 times, most recently
from
ae717d0 to
4755ce4
Compare
Collaborator
Author
|
Alright, I've decided to switch to a waiter set to reduce the effect of all the queue rechecking and also to help with the de-registering. |
Collaborator
Author
|
I've decided to rewrite this because I noticed a few other unsafe situations, I think it's safer to use mutexes to represent state rather than re-implementing that, for safety reasons. |
arihant2math
force-pushed
the
rwlock
branch
2 times, most recently
from
9a129d2 to
6579d9b
Compare
Collaborator
Author
|
Alright, I was able to massively simplify this by implementing internal state as per https://en.wikipedia.org/wiki/Readers%E2%80%93writer_lock#Using_two_mutexes. Should have no soundness issues since I'm not even touching atomics here. |
hexagonal-sun
requested changes
Feb 18, 2026
hexagonal-sun
approved these changes
Feb 19, 2026
Owner
hexagonal-sun
left a comment
hexagonal-sun
left a comment
There was a problem hiding this comment.
LGTM, ideally we'd have a bunch of unit tests too, but that can wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.