Implement sys_mincore
#160
Open
+128
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
hexagonal-sun
requested changes
Jan 15, 2026
Owner
hexagonal-sun
left a comment
hexagonal-sun
left a comment
There was a problem hiding this comment.
Couple of things:
- According to the man page
1is used if the page is resident in RAM. At the moment you're returning0, AFAICS. - You say that we don't have paging so we always return
0. I think what you're saying is that we never swap out pages so we can consider pages always resident in RAM? That isn't strictly true; we do have demand paging. Therefore, VMAs may well be partially resident in RAM. This is true for both anonymous and file-backed VMAs.
Collaborator
Author
|
Alright, I fixed the implementation and actually checked if pages were mapped or not. I actually didn't realize that we having demand paging. Also I've added a sanity test. |
hexagonal-sun
requested changes
Jan 20, 2026
Co-authored-by: Matthew Leach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't page, always returning
0is valid.