signal: interruptible: prioritize wrapped future over signals#167
Merged
hexagonal-sun merged 1 commit intomasterfrom Jan 17, 2026
Merged
signal: interruptible: prioritize wrapped future over signals#167hexagonal-sun merged 1 commit intomasterfrom
hexagonal-sun merged 1 commit intomasterfrom
Conversation
Poll the wrapped future first, ensuring that the interrupt logic doesn't short-circuit a future which is already ready. This fixes an issue where `sys_wait4` would return `-EINTR` when receiving a `SIGCHLD`. Since `SIGCHLD` indicates the wait condition is met, the underlying future is ready and should return the PID successfully rather than aborting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poll the wrapped future first, ensuring that the interrupt logic doesn't
short-circuit a future which is already ready.
This fixes an issue where
sys_wait4would return-EINTRwhenreceiving a
SIGCHLD. SinceSIGCHLDindicates the wait conditionis met, the underlying future is ready and should return the PID
successfully rather than aborting.